1328072 - [UX] [e10s] print preview opens print preview instead of showing alert like non-e10s (if printer was't found)

Status: NEW

(Core :: Print Preview, defect)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 48, 32bit, ID 20160403030243
STR_1:
1. Open page http://example.org/ in remote browser
2. Open menu bar (Alt or F10), click File->Print Preview

AR:  No alerts, print preview is shown.
ER:  Alert should be displayed, just like in non-e10s mode (non-e10s screencast in bug 1199434)

This difference was implemented in bug 1156742. Pushlog:
> https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=fa802cc2231d1933e64c2e27fcbcd17394563891&tochange=69e6782758af0cccc4cfd4bae482e4d5c61ff0da@ Bob Owen (:bobowen) (PTO until 3rd Jan):
It seems that this is a regresion caused by your change. Please have a look.

Comment 1

[Bob Owen (:bobowen)]

Setting NI to remind me to look into this.

Comment 2

[Bob Owen (:bobowen)]

I think to fix this (at least with the current print/print preview set-up code) we need to get the InitPrintSettingsFromPrinter to return NS_ERROR_GFX_PRINTER_NO_PRINTER_AVAILABLE and check the return value.

We need to make sure we check how this affects other callers of that function and to allow for things like print to PDF/PS where we don't need a printer.

[1] https://hg.mozilla.org/mozilla-central/file/8eaf154b385b/toolkit/components/printingui/ipc/PrintingParent.cpp#l141

Comment 3

[:Gijs (he/him)]

I ran into this trying to test bug 1332386... though tbh, we should really just make print preview work correctly when a printer isn't selected (ie select the next available printer)... Is there a separate bug on file for doing that? The no-action modal alert that just says "NOPE" to the user is pretty bad UI. :-(

Comment 4

[Mark Goodwin [:mgoodwin]]

Did you mean to ni? someone else here, Gijs?

Comment 5

[:Gijs (he/him)]

(In reply to Mark Goodwin [:mgoodwin] from comment #4)
> Did you mean to ni? someone else here, Gijs?

Err, yes, I think it was Bob who ventured near printing. Sorry!

(In reply to :Gijs from comment #3)
> I ran into this trying to test bug 1332386... though tbh, we should really
> just make print preview work correctly when a printer isn't selected (ie
> select the next available printer)... Is there a separate bug on file for
> doing that? The no-action modal alert that just says "NOPE" to the user is
> pretty bad UI. :-(

Comment 6

[Bob Owen (:bobowen)]

(In reply to :Gijs from comment #3)
> I ran into this trying to test bug 1332386... though tbh, we should really
> just make print preview work correctly when a printer isn't selected (ie
> select the next available printer)... Is there a separate bug on file for
> doing that? The no-action modal alert that just says "NOPE" to the user is
> pretty bad UI. :-(

I'm not quite clear what we think we should be fixing here.

Currently, for me print preview (when not printers are defined in the OS) displays the preview and when you click Print..., it displays the "Before you can perform printer-related tasks ..." message with the option to go to the printer setup.
This is the same as if you just attempt the print straight away without the preview.

This doesn't strike me as terrible, but we could change this to display this error without creating the print preview.

Gijs - is it the above that you think needs fixing or something else to do with printers being defined in the OS but not selected by Firefox (or both)?

Comment 7

[:Gijs (he/him)]

(In reply to Bob Owen (:bobowen) from comment #6)
> (In reply to :Gijs from comment #3)
> > I ran into this trying to test bug 1332386... though tbh, we should really
> > just make print preview work correctly when a printer isn't selected (ie
> > select the next available printer)... Is there a separate bug on file for
> > doing that? The no-action modal alert that just says "NOPE" to the user is
> > pretty bad UI. :-(
> 
> I'm not quite clear what we think we should be fixing here.
> 
> Currently, for me print preview (when not printers are defined in the OS)

Which platform is this on? I remember seeing the message in this screencast:

https://dl.dropboxusercontent.com/s/97pp74dtt5wwyod/Print%20preview%20-%20no%20printer%20-%20normal.webm?dl=0

("The selected printer could not be found")

on Windows 10, which isn't particularly helpful. Doing nothing and not working wasn't very helpful, either. Unfortunately, I don't know exactly how to reproduce this, though I expect it might work to simply set the selected printer (from about:config) to some printer id that the OS has forgotten about or something. Does that help clarify?

Comment 8

[Bob Owen (:bobowen)]

(In reply to :Gijs from comment #7)
> (In reply to Bob Owen (:bobowen) from comment #6)
> > (In reply to :Gijs from comment #3)
> > > I ran into this trying to test bug 1332386... though tbh, we should really
> > > just make print preview work correctly when a printer isn't selected (ie
> > > select the next available printer)... Is there a separate bug on file for
> > > doing that? The no-action modal alert that just says "NOPE" to the user is
> > > pretty bad UI. :-(
> > 
> > I'm not quite clear what we think we should be fixing here.
> > 
> > Currently, for me print preview (when not printers are defined in the OS)
> 
> Which platform is this on? I remember seeing the message in this screencast:

This is on Windows.
 
> https://dl.dropboxusercontent.com/s/97pp74dtt5wwyod/Print%20preview%20-
> %20no%20printer%20-%20normal.webm?dl=0
>
> ("The selected printer could not be found")

That looks like a different issue to me and to my mind worse than this one (if this one is thought an issue at all).

Possibly when a previously selected printer is unavailable for some reason, maybe network.
If I remove the currently selected printer I get the same dialog I described in comment 6, so it doesn't appear to be that.

I guess file a new bug, although we probably need STR for that to be useful.