Closed Bug 1199612 Opened 5 years ago Closed 5 years ago

[Messages][NG] API shim host didn't initialize correctly and break the MMS retrieval

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:2.5+)

RESOLVED FIXED
blocking-b2g 2.5+

People

(Reporter: steveck, Assigned: azasypkin)

References

Details

(Keywords: regression, Whiteboard: [sms-sprint-FxOS-S6])

Attachments

(1 file)

New shim bootstrap mechanism landed in bug 1169573 but didn't not enabled in main startup call path(only enabled in inbox startup). It will cause current MMS retrieval failed because it's the function implemented with NGA shim architecture.
Thanks for discovering this! Looks like I forgot to update shared/statup.js in PR for bug 1169576 :(

Will handle this and try to provide integration test.
Assignee: nobody → azasypkin
Blocks: 1169576
Status: NEW → ASSIGNED
No longer depends on: 1169576
Keywords: regression
Depends on: 1200116
Whiteboard: [sms-sprint-FxOS-S6]
Comment on attachment 8654720 [details] [review]
[gaia] azasypkin:bug-1199612-retrieve-mms > mozilla-b2g:master

Hey Steve,

Here is the patch that should fix the issue + simple integration test for the "retrieveMMS" case. Please see second commit only. The first commit is just the PR from bug 1169576 (that I've backed out today) that should be landed right before this PR.

What do you think about it?

Thanks!
Attachment #8654720 - Flags: review?(schung)
Blocking, as its a regression
blocking-b2g: 2.5? → 2.5+
Comment on attachment 8654720 [details] [review]
[gaia] azasypkin:bug-1199612-retrieve-mms > mozilla-b2g:master

Overall looks good and both device and browser works correctly. I only have some questions and r=me if we could move initShimHost to utils, thanks!
Attachment #8654720 - Flags: review?(schung) → review+
(In reply to Steve Chung [:steveck] from comment #5)
> Comment on attachment 8654720 [details] [review]
> [gaia] azasypkin:bug-1199612-retrieve-mms > mozilla-b2g:master
> 
> Overall looks good and both device and browser works correctly. I only have
> some questions and r=me if we could move initShimHost to utils, thanks!

Thanks for review! Moved "initShimHost" to utils and replied to your question. Treeherder is green, so landed:

Master: https://github.com/mozilla-b2g/gaia/commit/8fc65e5d6b1ab8da65383f21949ac614a17896a8
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.