1199612 - [Messages][NG] API shim host didn't initialize correctly and break the MMS retrieval

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Steve Chung [:steveck]]

New shim bootstrap mechanism landed in bug 1169573 but didn't not enabled in main startup call path(only enabled in inbox startup). It will cause current MMS retrieval failed because it's the function implemented with NGA shim architecture.

Comment 1

[Oleg Zasypkin [:azasypkin]]

Thanks for discovering this! Looks like I forgot to update shared/statup.js in PR for bug 1169576 :(

Will handle this and try to provide integration test.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] azasypkin:bug-1199612-retrieve-mms > mozilla-b2g:master

Comment 3

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8654720 [details] [review]
[gaia] azasypkin:bug-1199612-retrieve-mms > mozilla-b2g:master

Hey Steve,

Here is the patch that should fix the issue + simple integration test for the "retrieveMMS" case. Please see second commit only. The first commit is just the PR from bug 1169576 (that I've backed out today) that should be landed right before this PR.

What do you think about it?

Thanks!

Comment 4

[Mahendra Potharaju [:mahe]]

Blocking, as its a regression

Comment 5

[Steve Chung [:steveck]]

Comment on attachment 8654720 [details] [review]
[gaia] azasypkin:bug-1199612-retrieve-mms > mozilla-b2g:master

Overall looks good and both device and browser works correctly. I only have some questions and r=me if we could move initShimHost to utils, thanks!

Comment 6

[Oleg Zasypkin [:azasypkin]]

(In reply to Steve Chung [:steveck] from comment #5)
> Comment on attachment 8654720 [details] [review]
> [gaia] azasypkin:bug-1199612-retrieve-mms > mozilla-b2g:master
> 
> Overall looks good and both device and browser works correctly. I only have
> some questions and r=me if we could move initShimHost to utils, thanks!

Thanks for review! Moved "initShimHost" to utils and replied to your question. Treeherder is green, so landed:

Master: https://github.com/mozilla-b2g/gaia/commit/8fc65e5d6b1ab8da65383f21949ac614a17896a8