1200059 - [EME] Allow Adobe Primetime to work on MacOSX if available

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Our MediaKeySystemAccess implementation hard-codes Adobe EME to work only on Windows Vista and later. In order for Adobe to test EME on MacOSX, we need to loosen those restrictions to allow MacOSX to work too.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch: Make Primetime usable on MacOSX if CDM available

* Rearrange MediaKeySystemAccess to enable Primetime to work if the CDM is present.
* Use GMPTrialCreator where we expect the CDM to decode.
* Remove the old "access" keySystem string

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a4874d822e98

Comment 3

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8654672 [details] [diff] [review]
Patch: Make Primetime usable on MacOSX if CDM available

Review of attachment 8654672 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/eme/MediaKeySystemAccessManager.cpp
@@ +88,5 @@
> +    IsVistaOrLater();
> +#elif defined(XP_MACOSX)
> +    aKeySystem.EqualsLiteral("com.adobe.primetime") &&
> +    nsCocoaFeatures::OnLionOrLater();
> +#endif

Needs #else.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=292f99c8ce51

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d73f9e6c9cbb

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=29cff55b69e7

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b7ea89cda36e

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b7ea89cda36e

Comment 9

[Chris Pearce [:cpearce (Not reading bugmail)]]

Beta try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=23550dd24ed5

Rebased patch:
https://hg.mozilla.org/try/raw-rev/54f8a244fe62

Comment 10

[Chris Pearce [:cpearce (Not reading bugmail)]]

We need this uplift in order to uplift the patch in bug 1207439 which is blocking EME on Windows.

Comment 11

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8654672 [details] [diff] [review]
Patch: Make Primetime usable on MacOSX if CDM available

Approval Request Comment
[Feature/regressing bug #]: EME
[User impact if declined]: Won't be able to uplift bug 1207439, which means Firefox will crash when trying to startup the next version of Adobe's EME plugin.
[Describe test coverage new/current, TreeHerder]: We have lots of EME mochitests.
[Risks and why]: Low, this mostly affects MacOSX, and we're not shipping Adobe EME there.
[String/UUID change made/needed]: None.

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8654672 [details] [diff] [review]
Patch: Make Primetime usable on MacOSX if CDM available

Needed for a partner, taking it. Should be in 42.0b2.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e7ba2aa28649