1207439 - [EME] Don't use GMPVideoDecoderTrialCreator for Primetime

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

We should remove the GMPVideoDecoderTrialCreator. It's purpose was to ensure the Adobe GMP would be able to decode using WMF, but they no longer do, so we no longer need this.

It's also causing startup delay that's causing us to sometimes miss Netflix's 1 second navigator.requestMediaKeySystemAccess() deadline.

It's also failing for Adobe's latest dev drop CDM, even though Adobe's decoder is outputting a sensible sized frame; the test pattern should be 100x100, but WMF outputs 112x112, so we fail the trial create. And then we crash due to some bug in the trial-create-failed path.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Let's refine the goal here to just narrow the trial create to be used only for ClearKey on Windows, to make the patch smaller and easier to uplift. We also need to ensure we only try to use ClearKey WMF decoder when it's actually going to work, and we haven't got that fixed yet.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch: Don't trial create Adobe Primetime video decoder

Don't trial create the Adobe GMPVideoDecoder because it's not going to fail on random systems because of missing/broken WMF, and the trial create can be slow enough to make us miss Netflix's 1 second navigator.requestMediaKeySystemAccess deadline.

Leave the clearkey trial create in for now on Windows to make this patch easier to uplift.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Uplift required.

Will require bug 1205582 to be uplifted to apply cleanly.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9bcb36ef86d0

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Beta try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=23550dd24ed5

Beta rebased patch:
https://hg.mozilla.org/try/raw-rev/dbfae9f4d9ec

---

Aurora try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=219aaa6573b5

Aurora rebased patch:
https://hg.mozilla.org/try/raw-rev/cb84ac548219

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8665742 [details] [diff] [review]
Patch: Don't trial create Adobe Primetime video decoder

Approval Request Comment
[Feature/regressing bug #]: EME
[User impact if declined]: Firefox will crash when trying to use the next version of the Adobe EME plugin that Adobe will deliver soon.
[Describe test coverage new/current, TreeHerder]: We have tests covering EME and this feature.
[Risks and why]: Low; this turns off an optional code path.
[String/UUID change made/needed]: None.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8665742 [details] [diff] [review]
Patch: Don't trial create Adobe Primetime video decoder

Obviously, we don't want firefox to crash! Taking it. Should be in 42.0b2.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9bcb36ef86d0

Comment 9

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6f1393b541be

Comment 10

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f1b8f0d4fca2