1200146 - Injecting Functions from Content Scripts - Show "sourceless code"

Status: RESOLVED WORKSFORME

(WebExtensions :: Developer Tools, defect, P5)

Description

[ido.y]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/44.0.2403.155 Safari/537.36

Steps to reproduce:

we used a content script to inject script to the page

the function for injecting the script is
	function appendContentScript(id, content) {
		var scriptTag = document.createElement('script');
		scriptTag.id = id;
		scriptTag.type = 'text/javascript';
		scriptTag.appendChild( document.createTextNode(content) );
		head.appendChild(scriptTag);
	}


Actual results:

when we try to parse a function as content for example
function test() {
alert('hi, im test!');
}
we get the following script
<script type="text/javascript" id="SCRIPT_ID">function test() { [sourceless code] }</script>


Expected results:

<script type="text/javascript" id="SCRIPT_ID">function test() { alert('hi, im test!'); }</script>

Comment 1

[Kris Maglione [:kmag]]

Can you please attach a testcase add-on?

Comment 2

[ido.y]

Attachment: Extension.xpi

attached xpi

Comment 3

[Kris Maglione [:kmag]]

That add-on seems to work as expected for me.

In any case, I'd suggest converting the function to a string before passing it to createTextNode. And if you're using functions to inject code into pages like this, it would probably be best to always do something like `"(" + func + ")()"` rather than just injecting the bare function as a top-level function statement.

Comment 4

[ido.y]

when "running" the code in the console it seems to work fine (without converting the function)
should it be different ?

about the self execution - it was just an example :)