1200151 - KidFox: Restricted profiles - 'Developer tools' are always hidden

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Profile Handling, defect)

Description

[Catalin Suciu [:csuciu]]

Nexus 7 (5.1.1)
Latest Nightly/Aurora

Steps:
1. As 'owner', disable the 'Developer tools' restriction  
2. On the restricted profile open Firefox and go to -> Menu -> Settings  

Expected: Developer tools' menu item is displayed

Actual: 'Developer tools' menu item is not displayed

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Developer tools have been hidden based on whether the current profile is a guest or restricted profile. The restriction for "developer tools" has not been queried.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1200151 - Restricted profiles: Hide developer tools based on restriction. r?ally

Bug 1200151 - Restricted profiles: Hide developer tools based on restriction. r?ally

Comment 3

[Allison Naaktgeboren :ally]

From a product perspective, I question whether or not we actually want to allow owners to enable devtools. Kids could get into trouble? I think I'd favor removing the toggle from the UI. From a developer perspective, it's a royal pain to not have devtools.

Comment 4

[Allison Naaktgeboren :ally]

Comment on attachment 8654813 [details]
MozReview Request: Bug 1200151 - Restricted profiles: Hide developer tools based on restriction. r?ally

https://reviewboard.mozilla.org/r/17755/#review16051

So let's let people have devtools in restricted profiles and if we hear back from users that it's caused problems, we can back this out.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/71966f6ae764

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8654813 [details]
MozReview Request: Bug 1200151 - Restricted profiles: Hide developer tools based on restriction. r?ally

Approval Request Comment
[Feature/regressing bug #]: Bug 1125288 / KidFox (Targeting Fx42)
[User impact if declined]: Developer tools can't be activated for restricted profiles.
[Describe test coverage new/current, TreeHerder]: Manual testing, no UI test support for restricted profiles yet.
[Risks and why]: Low
[String/UUID change made/needed]: -

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/71966f6ae764

Comment 8

[Catalin Suciu [:csuciu]]

Verifying as fixed on latest Nightly.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8654813 [details]
MozReview Request: Bug 1200151 - Restricted profiles: Hide developer tools based on restriction. r?ally

Polish of a new feature, taking it.

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/437fb42ca436

Comment 11

[u549602]

Verifying as fixed on latest Aurora.