If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[B2G] [Emulator] support CDMA 3-way call

NEW
Unassigned

Status

Firefox OS
Emulator
2 years ago
a year ago

People

(Reporter: HoPang, Unassigned)

Tracking

(Blocks: 2 bugs)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 2 obsolete attachments)

(Reporter)

Description

2 years ago
Now, we have bugs for CDMA single call[1] and CDMA call waiting[2]. However, we need to support CDMA 3-way call as well to verify the conference feature of our WebAPI

[1] bug 1147296 - [B2G] [Emulator] Support CDMA call operations 
[2] bug 975779 - [B2G] [RIL] add marionette tests for CDMA call waiting
(Reporter)

Updated

2 years ago
Blocks: 865957
(Reporter)

Updated

2 years ago
Blocks: 1009393
(Reporter)

Updated

2 years ago
Assignee: nobody → bhsu
(Reporter)

Updated

2 years ago
Summary: [B2G][Emulator] support CDMA 3-way call → [B2G] [Emulator] support CDMA 3-way call
(Reporter)

Comment 1

2 years ago
Created attachment 8706195 [details] [diff] [review]
Part 1: Update some helper functions in head.js
(Reporter)

Comment 2

2 years ago
Created attachment 8706196 [details] [diff] [review]
Part 2: Add a new testcase
(Reporter)

Comment 3

2 years ago
Created attachment 8706197 [details] [diff] [review]
Part 3: Rearrange the comment of test_cdma_call_waiting.js
(Reporter)

Updated

2 years ago
Attachment #8706197 - Flags: review?(btseng)
(Reporter)

Updated

2 years ago
Attachment #8706196 - Flags: review?(btseng)
(Reporter)

Updated

2 years ago
Attachment #8706195 - Flags: review?(btseng)
Comment on attachment 8706195 [details] [diff] [review]
Part 1: Update some helper functions in head.js

Review of attachment 8706195 [details] [diff] [review]:
-----------------------------------------------------------------

r=me after the following nits are addressed.

Thanks!

::: dom/telephony/test/marionette/head.js
@@ +709,1 @@
>  

nit: shall we add the length-check of callsInTelephony, callsInConference here before verify the calls inside them?
is(callsInTelephony.length, telephony.calls.length);
is(callsInConference.length, telephony.conferenceGroup.calls.length);

@@ +709,3 @@
>  
>      // Check telephony.calls
> +    if (callsInTelephony.length) {

nit: It seems not necessary to check this before invoking Array.map() and Array.forEach()?

@@ +735,3 @@
>  
>      // Check conference.calls
> +    if (callsInConference.length) {

ditto.
Attachment #8706195 - Flags: review?(btseng) → review+
Comment on attachment 8706196 [details] [diff] [review]
Part 2: Add a new testcase

Review of attachment 8706196 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #8706196 - Flags: review?(btseng) → review+
Attachment #8706197 - Flags: review?(btseng) → review+
(Reporter)

Comment 6

2 years ago
Created attachment 8706843 [details] [review]
[external/qemu] pull request #176
(Reporter)

Updated

2 years ago
Attachment #8706843 - Attachment is obsolete: true
(Reporter)

Comment 7

2 years ago
Created attachment 8707365 [details] [diff] [review]
(V2) Part 1: Update some helper functions in head.js

Update a helper function in head.js.
Attachment #8706195 - Attachment is obsolete: true
Attachment #8707365 - Flags: review+
(Reporter)

Comment 8

2 years ago
Created attachment 8707370 [details] [review]
[external/qemu] pull request #177

Hi Edgar,

I implement these patches on Emulator-x86-kk this time, and they also work perfectly on Emulator-ics. Do you mind reviewing them?
Attachment #8707370 - Flags: review?(echen)
Comment on attachment 8707370 [details] [review]
[external/qemu] pull request #177

Looks good, r=me with the comments on github addressed or answered.

Since MNW is back now, please be careful about the landing sequence and if the emulator changes will break current test cases, you need to disable the tests first. BTW, do these changes need to be uplift to ics? 

Thank you.
Attachment #8707370 - Flags: review?(echen) → review+
(Reporter)

Updated

a year ago
Assignee: bhsu → nobody
You need to log in before you can comment on or make changes to this bug.