1200480 - [B2G] [Emulator] support CDMA 3-way call

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Emulator, defect)

Description

[Ben Hsu [:HoPang]]

Now, we have bugs for CDMA single call[1] and CDMA call waiting[2]. However, we need to support CDMA 3-way call as well to verify the conference feature of our WebAPI

[1] bug 1147296 - [B2G] [Emulator] Support CDMA call operations 
[2] bug 975779 - [B2G] [RIL] add marionette tests for CDMA call waiting

Comment 1

[Ben Hsu [:HoPang]]

Attachment: Part 1: Update some helper functions in head.js

Comment 2

[Ben Hsu [:HoPang]]

Attachment: Part 2: Add a new testcase

Comment 3

[Ben Hsu [:HoPang]]

Attachment: Part 3: Rearrange the comment of test_cdma_call_waiting.js

Comment 4

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8706195 [details] [diff] [review]
Part 1: Update some helper functions in head.js

Review of attachment 8706195 [details] [diff] [review]:
-----------------------------------------------------------------

r=me after the following nits are addressed.

Thanks!

::: dom/telephony/test/marionette/head.js
@@ +709,1 @@
>  

nit: shall we add the length-check of callsInTelephony, callsInConference here before verify the calls inside them?
is(callsInTelephony.length, telephony.calls.length);
is(callsInConference.length, telephony.conferenceGroup.calls.length);

@@ +709,3 @@
>  
>      // Check telephony.calls
> +    if (callsInTelephony.length) {

nit: It seems not necessary to check this before invoking Array.map() and Array.forEach()?

@@ +735,3 @@
>  
>      // Check conference.calls
> +    if (callsInConference.length) {

ditto.

Comment 5

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8706196 [details] [diff] [review]
Part 2: Add a new testcase

Review of attachment 8706196 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

Comment 6

[Ben Hsu [:HoPang]]

Attachment: [external/qemu] pull request #176

Comment 7

[Ben Hsu [:HoPang]]

Attachment: (V2) Part 1: Update some helper functions in head.js

Update a helper function in head.js.

Comment 8

[Ben Hsu [:HoPang]]

Attachment: [external/qemu] pull request #177

Hi Edgar,

I implement these patches on Emulator-x86-kk this time, and they also work perfectly on Emulator-ics. Do you mind reviewing them?

Comment 9

[Edgar Chen [:edgar]]

Comment on attachment 8707370 [details] [review]
[external/qemu] pull request #177

Looks good, r=me with the comments on github addressed or answered.

Since MNW is back now, please be careful about the landing sequence and if the emulator changes will break current test cases, you need to disable the tests first. BTW, do these changes need to be uplift to ics? 

Thank you.

Comment 10

[Hsin-Yi Tsai (she/her) [:hsinyi]]

I believe we can close this as wontfix as we don't support firefox os.