1200975 - [mozrunner] mozrunner>6.7 don't show the crash window

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Julien Pagès (:parkouss)]

So this happen at least on linux 64.

To reproduce, take one nightly build from say 2011-06-03:

mozdownload -t daily --date 2011-06-03
or
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2011/06/2011-06-03-03-mozilla-central/firefox-7.0a1.en-US.linux-x86_64.tar.bz2

untar it, then run:

> mozrunner --binary /path/to/bin/firefox

using latest 6.9, it just exit, nothing is shown. same thing with 6.8.

using mozrunner==6.7, a crash window is visible.

This looks like a regression.

Another thing to note, I am able to run:

> cd /path/to/bin/
> ./firefox

with success! Not sure if it is another bug.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Julien, can you please check 'pip freeze' for each mozrunner 6.7 and 6.8 installed? I wonder if it comes from another package, because between 6.7 and 6.8 I can only see the structured logging changes in mozrunner.

Comment 2

[Julien Pagès (:parkouss)]

Attachment: pipfreeze_6.7

Comment 3

[Julien Pagès (:parkouss)]

Attachment: pipfreeze_6.8

And running diff:

diff pipfreeze_6.8 pipfreeze_6.7
19c19
< mozrunner==6.8
---
> mozrunner==6.7

Comment 4

[Julien Pagès (:parkouss)]

So, looks like it comes from http://hg.mozilla.org/mozilla-central/annotate/fb720c90eb49/testing/mozbase/mozrunner/mozrunner/base/browser.py#l30, ie:

http://hg.mozilla.org/mozilla-central/rev/69701baa4c9f

coming from bug 1154761.

problem is that it is hardcoded. but using mozregression or mozrunner for example, nothing is shown, not even a crash log message. So this is hard to understand what is going on.

I think we should only activate that if a flag is given, or a command line. Or to deactivate it, if you really want this to be the default.

Comment 5

[James Graham [:jgraham]]

So the current behaviour is required to work well in automation, and to allow the use of a debugger. It's the responsibility of the caller to run mozcrash to look for any crash dump file that was created and log appropriately. It's hard for mozrunner to do that directly since it doesn't know about some parameters related to logging (e.g. it doesn't know about structured vs unstructured, or allow us to log which test was running at the time of the crash).

Comment 6

[Julien Pagès (:parkouss)]

Well, so what if I want to test that crash window from mozregression ? We need a way to at least activate it I think.

Comment 7

[James Graham [:jgraham]]

It's possible for mozregression to unset these variables if it's required for some specific use case.

Comment 8

[Julien Pagès (:parkouss)]

Hm yes. But it have to know that

GNOME_DISABLE_CRASH_DIALOG
XRE_NO_WINDOWS_CRASH_DIALOG

are defined by mozreg. And if we add another variable (I don't know, for KDE or something) or if one variable is renamed then it will break again...

Comment 9

[Julien Pagès (:parkouss)]

why not just add a disable_crash_window variable in __init__ that defaults to True ? I think I should then be able to pass it to False easily.

Comment 10

[(not currently active) Ted Mielczarek]

I think that would be fine.

Comment 11

[Julien Pagès (:parkouss)]

Attachment: MozReview Request: Bug 1200975 - [mozrunner] mozrunner>6.7 don't show the crash window. r=whimboo

Bug 1200975 - [mozrunner] mozrunner>6.7 don't show the crash window. r=whimboo

Comment 12

[Julien Pagès (:parkouss)]

So I tested it locally (using mozregression), works fine and do the job.

Comment 13

[James Graham [:jgraham]]

https://reviewboard.mozilla.org/r/18051/#review16155

::: testing/mozbase/mozrunner/mozrunner/base/browser.py:20
(Diff revision 1)
> +        self.crash_reporter_window = \

Please try to avoid using line continuation characters unless there is no alternative.

Comment 14

[Julien Pagès (:parkouss)]

Comment on attachment 8655929 [details]
MozReview Request: Bug 1200975 - [mozrunner] mozrunner>6.7 don't show the crash window. r=whimboo

Bug 1200975 - [mozrunner] mozrunner>6.7 don't show the crash window. r=whimboo

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8655929 [details]
MozReview Request: Bug 1200975 - [mozrunner] mozrunner>6.7 don't show the crash window. r=whimboo

https://reviewboard.mozilla.org/r/18051/#review16277

::: testing/mozbase/mozrunner/mozrunner/base/browser.py:23
(Diff revision 2)
> +        )

I would suggest we move this code some lines down to the environment variable handling. So it sticks together. This option shouldn't confuse the __init__ method of BaseRunner, right?

::: testing/mozbase/mozrunner/mozrunner/runners.py:28
(Diff revision 2)
> +        Defaults to False.

Maybe we name this option `show_crash_reporter`?

Comment 16

[Julien Pagès (:parkouss)]

https://reviewboard.mozilla.org/r/18051/#review16277

> I would suggest we move this code some lines down to the environment variable handling. So it sticks together. This option shouldn't confuse the __init__ method of BaseRunner, right?

Unfortunately we can't do that - the option WILL confuse BaseRunner.__init__:
https://dxr.mozilla.org/mozilla-central/source/testing/mozbase/mozrunner/mozrunner/base/runner.py#29

> Maybe we name this option `show_crash_reporter`?

I'm not against it, why not. :)

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+2]]

https://reviewboard.mozilla.org/r/18051/#review16277

> Unfortunately we can't do that - the option WILL confuse BaseRunner.__init__:
> https://dxr.mozilla.org/mozilla-central/source/testing/mozbase/mozrunner/mozrunner/base/runner.py#29

I see. So lets keep it. Maybe have it all in a single line? I assume we don't have a line limit of 80 chars in mozbase.

Comment 18

[Julien Pagès (:parkouss)]

Attachment: 1200975.patch

hm, had some issue with mozreview. Anyway, patch should be fixed. :)

Comment 19

[Julien Pagès (:parkouss)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a32fcc13375

Comment 20

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/39ed9e9defa7

Comment 21

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/39ed9e9defa7