1200987 - when a build crashes, the crash window is not shown

Status: RESOLVED WONTFIX

(Testing :: mozregression, defect)

Description

[Julien Pagès (:parkouss)]

Well this is a regression from mozrunner (>6.7, <=6.9). See bug 1200975.

Problem is that from mozregression we have no idea of what is happening when it crashes - just nothing is shown... Plus, we may want to find a regression around that window!

I think mozregression should print the sub process exit code when != 0 - so we can understand better what is happening.

Comment 1

[Julien Pagès (:parkouss)]

Attachment: warn when the process crashed with error code !=0

I tested it on Linuw and windows, this works fine.

Nothing printed when exitcode is 0 or when the user end the test by hitting good, bad or something.

Comment 2

[Julien Pagès (:parkouss)]

Comment on attachment 8656658 [details] [review]
warn when the process crashed with error code !=0

wrong bug.

Comment 3

[Julien Pagès (:parkouss)]

Since we fixed bug 1201527, I am not sure anymore if we need that fix.

We do not need the crash window since we now have a warning print for a wrong exit status, except in case it is a bisection to find a bug around the crashwindow !

Comment 4

[William Lachance (:wlach)]

(In reply to Julien Pagès from comment #3)
> Since we fixed bug 1201527, I am not sure anymore if we need that fix.
> 
> We do not need the crash window since we now have a warning print for a
> wrong exit status, except in case it is a bisection to find a bug around the
> crashwindow !

I'm not sure if I understand, what's the question?

Comment 5

[Julien Pagès (:parkouss)]

Well, I wonder if someone needs to see the crash window, since now we are printing the exit code if != 0.

So my question is: should we continue to work on this (add a flag to allow the crash window to be displayed) or should we just close this bug as WONTFIX ?

The real issue there was that it was hard to understand if a browser was closed due to some unwanted click or due to a crash.

Comment 6

[William Lachance (:wlach)]

Right. I feel like we should disable crash reporting from mozregression. It's known that old builds can and do crash, often we're using mozregression to bisect the root cause of this. :)

Comment 7

[Julien Pagès (:parkouss)]

Allright then - let's close this bug as WONTFIX since this is disabled by default.