1201129 - Please sign the plugin update network.auth.allow-subresource-auth hotfix xpi (v20150902.01)

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Administration, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

To generate the XPI, do the following:

hg clone https://hg.mozilla.org/releases/firefox-hotfixes
cd firefox-hotfixes
HOTFIX=v20150902.01 make package

Then we need to sign the xpi generated at build/hotfix-v20150902.01.xpi

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Jorge, Jason, could you help here? thanks

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

Attachment: Unsigned hotfix

Here's the unsigned file. I'll note that I changed the maxVersion in install.rdf from 40.0.* to 40.*, since the former isn't valid on AMO. I've brought this up before and should be fixed in the repo (I'm not sure who's in charge of that).

Kris or Jason can have it signed.

Comment 3

[Jason Thomas [:jason]]

Attachment: Signed Hotfix

Please see attached.

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

The hotfix is now staged and needs testing before pushing live.

Comment 5

[Andrei Vaida [:avaida]]

I've just tried testing this on Firefox 40.0.3 (20150826023504) using Windows 10 x64, but I'm getting an unrecognized certificate issuer error for mozilla_firefox_hotfix-20150902.01-fx.xpi.

Here are the logs:
> 1441265894870	addons.update-checker	DEBUG	Found an update entry for [e-mail] version 20150902.01
> 1441265894876	addons.manager	DEBUG	Downloading hotfix version 20150902.01
> 1441265894879	addons.manager	DEBUG	Background update check complete
> 1441265894886	addons.xpi	DEBUG	Download started for https://addons-dev-cdn.allizom.org/user-media/addons/354399/mozilla_firefox_hotfix-20150902.01-fx.xpi?filehash=sha256%3Acbc52296164b960514ac183a9621be720937e73bc368ad0527ca8c2814714df1 to file C:\Users\ANDREI~1.VAI\AppData\Local\Temp\tmp-unn.xpi
> 1441265894903	addons.xpi	DEBUG	Download of https://addons-dev-cdn.allizom.org/user-media/addons/354399/mozilla_firefox_hotfix-20150902.01-fx.xpi?filehash=sha256%3Acbc52296164b960514ac183a9621be720937e73bc368ad0527ca8c2814714df1 completed.
> Signature Verification Error: the signature on this .jar archive is invalid because the certificate used to sign this file has an unrecognized issuer.
> A required certificate was not present. CertUtils.jsm:80:0

I've followed the instructions available on MDN [1], Jorge-- is there something I'm missing here?


[1] https://developer.mozilla.org/en-US/Add-ons/Hotfix#Testing_the_hotfix_on_the_staging_server

Comment 6

[Jason Thomas [:jason]]

Attachment: Signed Hotfix

The previous hotfix was missing the CA Certificate which most likely caused the signature error. I've adjusted the server side config and I've signed this hotfix again. Jorge could you stage this hotfix for testing?

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Andrei, could you check that? Thanks

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

Attachment: Unsiged hotfix, bumped version

AMO doesn't handle well multiple uploads with the same version number, so we need to bump the version up before trying again. Here's the unsigned version for signing again.

Comment 9

[Jason Thomas [:jason]]

Attachment: Signed Hotfix

Please see attached.

Comment 10

[Jorge Villalobos [:jorgev] (he/him)]

Okay, the new version of the hotfix is now staged. Please try again.

Comment 11

[Andrei Vaida [:avaida]]

Windows 10 x64 - PASSED
• tested with: 40.0 , 40.0.1, 40.0.2, 40.0.3
Mac OS X 10.10.4 - PASSED
• tested with: 40.0 , 40.0.1, 40.0.2, 40.0.3
Ubuntu 14.04 86 - PASSED
• tested with: 40.0 , 40.0.1, 40.0.2, 40.0.3

The following were confirmed on each version and platform after manually triggering the update check:
• hotfix installed successfully
• network.auth.allow-subresource-auth changed to 2
• accessing (e.g.) http://uchug.org/page13.html brings up the auth dialog

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Jorge, I think we are good to go live. Could you push it? Thanks

Comment 13

[Jorge Villalobos [:jorgev] (he/him)]

The new hotfix is now live on AMO.