1201497 - Theme URL is not automatically modified when trying to submit a Theme with the same name as an Addon

Status: RESOLVED INCOMPLETE

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Valentina Virlics [:vvalentina], Ecosystem QA]

Steps to reproduce:
1. Load AMO-dev page https://addons-dev.allizom.org/en-US/firefox/
2. Go to Tools->Submit a New Theme
3. Give the theme the same name as an already submitted addon (i.e. same_name)

Expected results:
The theme can be submitted. The theme's slug is automatically modified (like in the case of search tool/dictionaries; an “-1”/”-2” etc., is added at the end of the URL)

Actual results:
The slug must be manually changed.

Notes/Issues:
Verified on FF40(Win 7). Issue is reproducing on AMO-stage, dev and prod.
Please see the screenshots: http://screencast.com/t/xUDq2iC83Yps

Comment 1

[Mathieu Agopian [:magopian]]

When submitting a standard add-on, the slug is cleaned and has a suffix appended if it already exists using https://github.com/mozilla/olympia/blob/5bdfd54723ee13fccc452d95de7eeeeb6e2f1cce/apps/addons/models.py#L55

It seems that's not done for themes.

Comment 2

[u557993]

Hi I'd like to start on fixing my first bug. If anyone can give my some guidance, that'd be awesome

Comment 3

[Mathieu Agopian [:magopian]]

The "clean_slug" helper linked above is used in the Addon.save() method (see https://github.com/mozilla/olympia/blob/5bdfd54723ee13fccc452d95de7eeeeb6e2f1cce/apps/addons/models.py#L405). My first attempt would be to create a save() method on the Persona model, with a call to "clean_slug", and check to see if that fixes it.

Comment 4

[Amy Tsay [:amyt]]

Assigning to Deepthi as his first goodfirstbug--welcome! Please comment here with any questions.