1201505 - Add visual cues and modifications to the browsing UI to indicate that we're in Private mode

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect)

Description

[Stephan Leroux [:sleroux]]

We'll need a way to allow users to visually differentiate between private and normal tabs. This includes:

- Visual cues while browsing that the current tab is private vs normal
- Visual cues on the tab tray that show if a tab in the tray is private vs normal

Comment 1

[Stephan Leroux [:sleroux]]

Same comment from https://bugzilla.mozilla.org/show_bug.cgi?id=1201504

Comment 2

[Stephan Leroux [:sleroux]]

Attachment: https://github.com/mozilla/firefox-ios/pull/1095

Comment 3

[Darrin Henein [:darrin]]

Attachment: Screen Shot 2015-09-22 at 4.20.44 PM.png

3 quick nits, will play more with it though:

1. outline on selected url bar should be purple
2. text highlight color should be lavender and more readable
3. tab button stroke width should be 1pt, not 2pt

Colors in screenshot, in r/g/b format.

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 8664409 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1095

Looking good, just want to see the next iteration with fixups and UX nits addressed.

Comment 5

[Stephan Leroux [:sleroux]]

Updated with code nits/ui nit fixes

Comment 6

[Emily Toop (:fluffyemily)]

Comment on attachment 8664409 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1095

Can't say I particularly like the purple tab counter, but that's just a personal preference.

Comment 7

[Darrin Henein [:darrin]]

Comment on attachment 8664409 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1095

Love it, now for animations :)

Comment 8

[Stephan Leroux [:sleroux]]

Comment on attachment 8664409 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1095

Flagging for PR fix review

Comment 9

[Brian Nicholson (:bnicholson)]

Comment on attachment 8664409 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1095

LGTM with autocomplete highlight fixed.

Comment 10

[Stephan Leroux [:sleroux]]

Ah thanks for find this. I've fixed it and will merge this down to master.

Comment 11

[Stephan Leroux [:sleroux]]

Merged.

Comment 12

[Catalin Suciu [:csuciu]]

Verifying as fixed on the current TestFlight build (1104)