Closed Bug 1201505 Opened 10 years ago Closed 10 years ago

Add visual cues and modifications to the browsing UI to indicate that we're in Private mode

Categories

(Firefox for iOS :: General, defect)

Product:
Firefox for iOS
Component:
General
Platform:
Other
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
fxios 1.1+ ---

People

(Reporter: sleroux, Assigned: sleroux)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

https://github.com/mozilla/firefox-ios/pull/1095
48 bytes, text/x-github-pull-request
fluffyemily
: review+
bnicholson
: review+
dhenein
: ui-review+
Details | Review
Screen Shot 2015-09-22 at 4.20.44 PM.png
26.17 KB, image/png
Details
We'll need a way to allow users to visually differentiate between private and normal tabs. This includes: - Visual cues while browsing that the current tab is private vs normal - Visual cues on the tab tray that show if a tab in the tray is private vs normal
Same comment from https://bugzilla.mozilla.org/show_bug.cgi?id=1201504
Flags: needinfo?(randersen)
Flags: needinfo?(randersen)
Blocks: 1202816
No longer blocks: 1202816
Assignee: nobody → sleroux
Depends on: 1206734
Attachment #8664409 - Flags: ui-review?(dhenein)
Attachment #8664409 - Flags: review?(etoop)
Attachment #8664409 - Flags: review?(bnicholson)
3 quick nits, will play more with it though: 1. outline on selected url bar should be purple 2. text highlight color should be lavender and more readable 3. tab button stroke width should be 1pt, not 2pt Colors in screenshot, in r/g/b format.
Comment on attachment 8664409 [details] [review] https://github.com/mozilla/firefox-ios/pull/1095 Looking good, just want to see the next iteration with fixups and UX nits addressed.
Attachment #8664409 - Flags: review?(bnicholson) → feedback+
Updated with code nits/ui nit fixes
Comment on attachment 8664409 [details] [review] https://github.com/mozilla/firefox-ios/pull/1095 Can't say I particularly like the purple tab counter, but that's just a personal preference.
Attachment #8664409 - Flags: review?(etoop) → review+
Blocks: 1207593
Comment on attachment 8664409 [details] [review] https://github.com/mozilla/firefox-ios/pull/1095 Love it, now for animations :)
Attachment #8664409 - Flags: ui-review?(dhenein) → ui-review+
Status: NEW → ASSIGNED
Comment on attachment 8664409 [details] [review] https://github.com/mozilla/firefox-ios/pull/1095 Flagging for PR fix review
Attachment #8664409 - Flags: review?(bnicholson)
Comment on attachment 8664409 [details] [review] https://github.com/mozilla/firefox-ios/pull/1095 LGTM with autocomplete highlight fixed.
Attachment #8664409 - Flags: review?(bnicholson) → review+
Attachment #8664409 - Flags: feedback+
Ah thanks for find this. I've fixed it and will merge this down to master.
Merged.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Verifying as fixed on the current TestFlight build (1104)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: