1201766 - loading icon chrome://browser/skin/tabbrowser/loading.png is not animated under system libpng 1.6 (linux)

Status: UNCONFIRMED

(Firefox :: Theme, defect)

Description

[broken.zhou]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150903161829

Steps to reproduce:

Build firefox using system libpng 1.6


Actual results:

loading icon chrome://browser/skin/tabbrowser/loading.png is not animated


Expected results:

loading icon chrome://browser/skin/tabbrowser/loading.png should be animated.

Downstream need to patch the icon by themselves. (e.g. https://projects.archlinux.org/svntogit/packages.git/tree/trunk?h=packages/firefox)

Please replace the icon with a more standard APNG, for example https://projects.archlinux.org/svntogit/packages.git/plain/trunk/firefox-fixed-loading-icon.png?h=packages/firefox.

Comment 1

[broken.zhou]

For some literature, see https://bugs.archlinux.org/task/37576 and https://bbs.archlinux.org/viewtopic.php?id=172182&p=3

Comment 2

[broken.zhou]

Also https://bugzilla.mozilla.org/show_bug.cgi?id=841734.

Comment 3

[Glenn Randers-Pehrson]

I can't find the "loading.png" that you mentioned.  I found these in my tree, but they all animate properly:

./browser/themes/windows/tabbrowser/loading.png
./browser/themes/linux/tabbrowser/loading.png
./browser/themes/osx/tabbrowser/loading.png

Comment 4

[broken.zhou]

The loading.png is located in browser/themes/linux/tabbrowser/loading.png in gecko-dev tree.

To reprocedure, you should use a self-compiled firefox with system-wide libpng 1.6 under linux.  It seems that the libpng shipped with firefox is patched to have a stronger compatibility.

Comment 5

[Glenn Randers-Pehrson]

If you are using a system libpng-1.6 that does not support APNG then you are getting the expected behavior.  One still frame, not an animation.  I'm running nightly with the embedded, APNG-supporting libpng-1.6.18. You should build your system libpng after applying to it the "apng.patch" that's included in media/libpng.

Comment 6

[broken.zhou]

That's strange.  I think my libpng is patched and my firefox can even show browser/themes/windows/tabbrowser/loading.png animated.  But when I view ./browser/themes/linux/tabbrowser/loading.png, I just get a full transparent image that is still.

Comment 7

[broken.zhou]

To make it clear, the browser/themes/linux/tabbrowser/loading.png only goes wrong then you use a external official libpng (build with --with-system-png), even if that that libpng is patched with apng.patch.

The internal libpng shipped with firefox is not affected.

Comment 8

[Glenn Randers-Pehrson]

In that case please tell us which version of libpng you've installed.  Are you sure that the linker is finding the patched libpng and not another libpng somewhere on your system?  Use "ldd firefox" to find out.

Comment 9

[Maxim Mikityanskiy]

I'm experiencing the similar problem. I'm also on Gentoo, libpng 1.6.18 (apng enabled), Firefox 41.0.2 (built with system libpng). No loading.png is shown at all, there is just a blank space where the icon should be present in tabbar. Trying to open chrome://browser/skin/tabbrowser/loading.png leads to the following error in console (Ctrl+Shift+K): "Image corrupt or truncated.", no image is visible.

ldd doesn't show any libpng:

	linux-vdso.so.1 (0x00007ffca49ed000)
	libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f899e183000)
	libdl.so.2 => /lib64/libdl.so.2 (0x00007f899df7f000)
	libstdc++.so.6 => /usr/lib/gcc/x86_64-pc-linux-gnu/5.2.0/libstdc++.so.6 (0x00007f899dbfc000)
	libm.so.6 => /lib64/libm.so.6 (0x00007f899d908000)
	libgcc_s.so.1 => /usr/lib/gcc/x86_64-pc-linux-gnu/5.2.0/libgcc_s.so.1 (0x00007f899d6f1000)
	libc.so.6 => /lib64/libc.so.6 (0x00007f899d354000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f899e39f000)

Comment 11

[Jan Alexander Steffens [:heftig]]

Still happens here (libpng 1.6.21 with APNG patch on Arch Linux x86_64). The fixed image from attachment #748550 [details] displays properly with both system libpng and tree libpng, while the image from the tree is broken with system libpng (libxul links against /usr/lib/libpng16.so.16).