Tooltip arrow is very huge on HiDPI

VERIFIED FIXED in Firefox 46

Status

defect
VERIFIED FIXED
4 years ago
11 months ago

People

(Reporter: arni2033, Assigned: ntim)

Tracking

(Blocks 1 bug, {regression})

Trunk
Firefox 47
Dependency tree / graph

Firefox Tracking Flags

(firefox43 wontfix, firefox44 wontfix, firefox45- wontfix, firefox46+ verified, firefox47+ verified)

Details

()

Attachments

(3 attachments)

Reporter

Description

4 years ago
STR:   (Win7_64, Nightly 43, 32bit, ID 20150901030226, new profile, safe mode)
0. Set layout.css.devPixelsPerPx -> 1.2 (or set DPI 120% in your OS)
1. Open the following page or click URL in the form above
data:text/html,<div style="background:url(chrome://browser/skin/tabbrowser/loading@2x.png); height:100px; width:100px;">
2. Open devtools->Inspector, inspect <div>, open "Rules" panel
3. Hover mouse over the url in that pane

Result: tooltip arrow looks way bigger than with layout.css.devPixelsPerPx == 1.0. I can say it because its width equals to ~3-4 characters in normal mode (layout.css.devPixelsPerPx == 1.0) and equals to ~7-8 characters in zoomed in mode (layout.css.devPixelsPerPx == 1.2)

Expectations: Tooltip arrow should be of normal size
Reporter

Updated

3 years ago
Has STR: --- → yes
Reporter

Updated

3 years ago
Blocks: win-hidpi
Assignee

Comment 2

3 years ago
arni2033, thanks for filing and finding the regression range !
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Assignee

Updated

3 years ago
Attachment #8719327 - Attachment description: MozReview Request: Bug 1201829 - Fix devtools tooltip arrows on HDPI. r=pbro → MozReview Request: Bug 1201829 - Fix devtools tooltip arrows on HDPI screens. r=pbrosset
Attachment #8719327 - Flags: review?(pbrosset)
Assignee

Comment 4

3 years ago
Comment on attachment 8719327 [details]
MozReview Request: Bug 1201829 - Fix devtools tooltip arrows on HDPI screens. r=pbrosset

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/34931/diff/1-2/
Assignee

Comment 5

3 years ago
Patrick, I haven't tested this patch on Windows, any chance you could test it for me ? Thanks.
Posted image arrow-1.2.png
Tested on windows 10, by setting layout.css.devPixelsPerPx to 1.2.
The size of the arrow seems right. The border around the arrow is slightly thinner than that around the tooltip though, but maybe that's a different issue.
Also, the arrow isn't pointed exactly at the color swatch, but that, for sure, is a separate issue (which I've filed, but can't find again).
Reporter

Comment 7

3 years ago
(In reply to Patrick Brosset [:pbrosset] [:pbro] from comment #6)
> the arrow isn't pointed exactly at the color swatch
Bug 1149489. I didn't know it was a bug.
Comment on attachment 8719327 [details]
MozReview Request: Bug 1201829 - Fix devtools tooltip arrows on HDPI screens. r=pbrosset

https://reviewboard.mozilla.org/r/34931/#review31633

::: devtools/client/themes/dark-theme.css:325
(Diff revision 2)
> +  height: 16px !important;

Why is `!important` needed here? If we really don't have a choice (like making the selector more specific), then at least we need a comment that explains why.
Attachment #8719327 - Flags: review?(pbrosset)
Assignee

Comment 9

3 years ago
(In reply to Patrick Brosset [:pbrosset] [:pbro] from comment #6)
> Created attachment 8719715 [details]
> arrow-1.2.png
> 
> Tested on windows 10, by setting layout.css.devPixelsPerPx to 1.2.
> The size of the arrow seems right. The border around the arrow is slightly
> thinner than that around the tooltip though, but maybe that's a different
> issue.
That's because the images were made that way, it would require changing them to fix that.
Assignee

Comment 10

3 years ago
Comment on attachment 8719327 [details]
MozReview Request: Bug 1201829 - Fix devtools tooltip arrows on HDPI screens. r=pbrosset

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/34931/diff/2-3/
Attachment #8719327 - Flags: review?(pbrosset)
Comment on attachment 8719327 [details]
MozReview Request: Bug 1201829 - Fix devtools tooltip arrows on HDPI screens. r=pbrosset

https://reviewboard.mozilla.org/r/34931/#review33591

Thanks for adding the comments.
Attachment #8719327 - Flags: review?(pbrosset) → review+
Assignee

Comment 13

3 years ago
Comment on attachment 8719327 [details]
MozReview Request: Bug 1201829 - Fix devtools tooltip arrows on HDPI screens. r=pbrosset

Approval Request Comment
[Feature/regressing bug #]: bug 1023546
[User impact if declined]: Huge devtools tooltip arrow for HDPI (see attachment 8657028 [details])
[Describe test coverage new/current, TreeHerder]: Will land in Nightly, tested locally on Windows and OSX.
[Risks and why]: Low, CSS only fix.
[String/UUID change made/needed]: no
Attachment #8719327 - Flags: approval-mozilla-beta?
Attachment #8719327 - Flags: approval-mozilla-aurora?
Assignee

Comment 14

3 years ago
[Tracking Requested - why for this release]: Visual regression.

Comment 15

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a2e1c335d3d1
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Comment on attachment 8719327 [details]
MozReview Request: Bug 1201829 - Fix devtools tooltip arrows on HDPI screens. r=pbrosset

This is too late for 45 but taking it for 46.
Attachment #8719327 - Flags: approval-mozilla-beta?
Attachment #8719327 - Flags: approval-mozilla-beta-
Attachment #8719327 - Flags: approval-mozilla-aurora?
Attachment #8719327 - Flags: approval-mozilla-aurora+
Reporter

Comment 18

3 years ago
Fixed on:   Win7_64, Nightly 47, 32bit, ID 20160229030448
Status: RESOLVED → VERIFIED

Comment 19

3 years ago
[bugday-20160323]

Status: RESOLVED,FIXED -> VERIFIED

Comments:
Test Successful

Component: 
Name 			Firefox
Version 		46.0b9
Build ID 		20160322075646
Update Channel 	        beta
User Agent 		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS                      Windows 7 SP1 x86_64

Expected Results: 
Tooltip arrow is of same size as that element loading in that particular page

Actual Results: 
As expected

Updated

11 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.