1201838 - Printing tasks is broken [Error: TypeError: aItem[cal.calGetStartDateProp(...)] is null]

Status: RESOLVED FIXED

Description

[Stefan Sitter]

Lightning 4.4a2 (20150902004005) with Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0) Gecko/20100101 Thunderbird/42.0a2

Trying to printing calendar that contains tasks with only due date is broken in monthly and weekly layout. The following errors are reported:

Error: TypeError: aItem[cal.calGetStartDateProp(...)] is null
Source File: resource://calendar/modules/calPrintUtils.jsm Line: 164

Error: Calendar print dialog:refreshHtml: [Exception... "[JavaScript Error: "aItem[cal.calGetStartDateProp(...)] is null" {file: "resource://calendar/modules/calPrintUtils.jsm" line: 164}]'[JavaScript Error: "aItem[cal.calGetStartDateProp(...)] is null" {file: "resource://calendar/modules/calPrintUtils.jsm" line: 164}]' when calling method: [calIPrintFormatter::formatToHtml]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://calendar/content/calendar-print-dialog.js :: getSettingsResponse :: line 205"  data: yes]
Source File: chrome://calendar/content/calendar-print-dialog.js Line: 226

Might be regression from Bug 359007.

Comment 1

[Stefan Sitter]

Created attachment 8657051 [details] [diff] [review]
handle tasks without start date or due date or both

Restore previous behavior for tasks without start date or due date or both.

Comment 2

[Philipp Kewisch [:Fallen]]

Comment on attachment 8657051 [details] [diff] [review]
handle tasks without start date or due date or both

Review of attachment 8657051 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=philipp. Thanks for the patch!

Comment 3

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/ba74dfc111e2ef138a98bee3d76a4c3a8309ae5d
Bug 1201838 - Printing tasks is broken [Error: TypeError: aItem[cal.calGetStartDateProp(...)] is null]. r=Fallen a=aleth SM CLOSED TREE

Comment 4

[Stefan Sitter]

Comment on attachment 8657051 [details] [diff] [review]
handle tasks without start date or due date or both

Fix is required for Lightning 4.4 too.

Comment 5

[Philipp Kewisch [:Fallen]]

Backported to releases/comm-aurora changeset c5e0f88e8a9f