Closed
Bug 1201982
Opened 9 years ago
Closed 8 years ago
Add an fa-pencil hover to Sheriff panel editable values
Categories
(Tree Management :: Treeherder, defect, P4)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jfrench, Assigned: KWierso)
Details
Attachments
(1 file)
Begat from the work in bug 1193951 / https://github.com/mozilla/treeherder/pull/933 which improved the layout of the Sheriff panel, we discussed the idea of adding an fa-pencil on hover to the right side of any editable value. For example, the Exclusion profile names, and the Job exclusion names. This will further cue the user they are an editable values, rather than just being an underlined link with a tooltip. This bug represents that work.
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8750054 [details] [review] [treeherder] KWierso:bug1201982 > mozilla:master And another. I also included a change to make some of the surrounding CSS use four-space indents like the rest of the file. Happy to drop those if you don't want them as part of this. :)
Attachment #8750054 -
Flags: review?(emorley)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → wkocher
Updated•8 years ago
|
Attachment #8750054 -
Flags: review?(emorley) → review+
Comment 3•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/d979c5b888ea059b329a3c94a63f1c03902b4e46 Bug 1201982 - Add fa-pencil on hover for sheriff panel job exclusion entries This adds a pencil icon when you hover over a job exclusion in the sheriff panel list. Also included are some spacing fixes for CSS around the changes I made.
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•