If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Add an fa-pencil hover to Sheriff panel editable values

RESOLVED FIXED

Status

Tree Management
Treeherder
P4
minor
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: jfrench, Assigned: KWierso)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Begat from the work in bug 1193951 / https://github.com/mozilla/treeherder/pull/933 which improved the layout of the Sheriff panel, we discussed the idea of adding an fa-pencil on hover to the right side of any editable value. For example, the Exclusion profile names, and the Job exclusion names.

This will further cue the user they are an editable values, rather than just being an underlined link with a tooltip.

This bug represents that work.

Comment 1

a year ago
Created attachment 8750054 [details] [review]
[treeherder] KWierso:bug1201982 > mozilla:master
(Assignee)

Comment 2

a year ago
Comment on attachment 8750054 [details] [review]
[treeherder] KWierso:bug1201982 > mozilla:master

And another. 

I also included a change to make some of the surrounding CSS use four-space indents like the rest of the file. Happy to drop those if you don't want them as part of this. :)
Attachment #8750054 - Flags: review?(emorley)
(Assignee)

Updated

a year ago
Assignee: nobody → wkocher

Updated

a year ago
Attachment #8750054 - Flags: review?(emorley) → review+

Comment 3

a year ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/d979c5b888ea059b329a3c94a63f1c03902b4e46
Bug 1201982 - Add fa-pencil on hover for sheriff panel job exclusion
entries

This adds a pencil icon when you hover over a job exclusion in the sheriff
panel list. Also included are some spacing fixes for CSS around the
changes I made.

Updated

a year ago
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.