1202001 - Syntax errors in service workers aren't logged to the web console

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Marco Castelluccio [:marco]]

They are logged in the browser console.

Comment 1

[Josh Matthews [:jdm]]

Even with the service workers logging option turned on in the web console?

Comment 2

[Marco Castelluccio [:marco]]

(In reply to Josh Matthews [:jdm] from comment #1)
> Even with the service workers logging option turned on in the web console?

Yes.
In the fetch event handler, I've added:
> console.log("HERE");
> var prova;
> prova.asdasd = 4;

In the web console I only see the "HERE" message.
In the browser console I see the "HERE" message followed by "TypeError: prova is undefined".

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

The problem is the service worker never provides a window ID here:

  https://dxr.mozilla.org/mozilla-central/source/dom/workers/ServiceWorkerPrivate.cpp#339

Comment 4

[(no longer active)]

Attachment: Log errors emitted during service worker lifecycle events to the Web Console

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8678612 [details] [diff] [review]
Log errors emitted during service worker lifecycle events to the Web Console

Review of attachment 8678612 [details] [diff] [review]:
-----------------------------------------------------------------

r=me not to use ID 0 any more.  It seems its preferred to use UINT64_MAX for invalid window ID.

That being said, I don't think WorkerPrivate::WindowID() will ever return a real window for a service worker.

So I don't think this will actually fix the problem described in this bug.  Did you see it work for you?

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

So, I am adding an nsILogCollector interface in bug 1215140.  The purpose is to let us save console messages OMT, and then later log them to the correct window.  We could possibly make WorkerPrivate implement this interface and then have SWM log the messages to the window calling .register().

Comment 7

[(no longer active)]

I definitely am seeing an error reported to the web console after this patch on https://ehsan.github.io/sw-versioning/index2.html.  That's a simple test case where we register a SW containing a syntax error ("for(;;;;){}").

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b1095ad5a4b8

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b1095ad5a4b8