Closed
Bug 1202016
Opened 9 years ago
Closed 9 years ago
Prevent submission of add-ons with GUIDs longer than 64 chars
Categories
(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)
addons.mozilla.org Graveyard
Admin/Editor Tools
Tracking
(Not tracked)
VERIFIED
FIXED
2015-09-10
People
(Reporter: magopian, Assigned: magopian)
References
Details
This is linked to bug 1201176, and implements the "prevent future occurrences of the issue": we need to prevent the submission of add-ons with GUIDs longer than 64 chars, as they result in an incorrect signature.
Assignee | ||
Comment 1•9 years ago
|
||
PR: https://github.com/mozilla/olympia/pull/717
Comment 2•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/olympia https://github.com/mozilla/olympia/commit/8d1fb1e23aad27558698947325930264f8531c59 Reject add-on submission if its guid is more than 64chars (bug 1202016) https://github.com/mozilla/olympia/commit/77a3b9d75b4a3e257103e92fbe26fc99b5c20263 Merge pull request #717 from magopian/1202016-reject-addon-submission-if-guid-too-long Reject add-on submission if its guid is more than 64chars (bug 1202016)
Assignee | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2015-09-10
Comment 3•9 years ago
|
||
When submitting an addon with more than 64 chars there is a warning message displayed, but when using the stand alone validator that warning is not displayed: http://screencast.com/t/syLa0GjsZv Same warning should be displayed when using the stand alone validator. Reopening bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 4•9 years ago
|
||
The standalone validator doesn't enforce the sanity checks that are run when submitting an add-on for real. For example, the "Duplicate add-on ID found." message isn't shown either, if you only validate an add-on that re-uses an existing add-on ID. This is the expected behavior.
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•