Prevent submission of add-ons with GUIDs longer than 64 chars

VERIFIED FIXED in 2015-09-10

Status

VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: magopian, Assigned: magopian)

Tracking

unspecified
2015-09-10
Dependency tree / graph

Details

(Assignee)

Description

3 years ago
This is linked to bug 1201176, and implements the "prevent future occurrences of the issue": we need to prevent the submission of add-ons with GUIDs longer than 64 chars, as they result in an incorrect signature.

Comment 2

3 years ago
Commits pushed to master at https://github.com/mozilla/olympia

https://github.com/mozilla/olympia/commit/8d1fb1e23aad27558698947325930264f8531c59
Reject add-on submission if its guid is more than 64chars (bug 1202016)

https://github.com/mozilla/olympia/commit/77a3b9d75b4a3e257103e92fbe26fc99b5c20263
Merge pull request #717 from magopian/1202016-reject-addon-submission-if-guid-too-long

Reject add-on submission if its guid is more than 64chars (bug 1202016)
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2015-09-10

Comment 3

3 years ago
When submitting an addon with more than 64 chars there is a warning message displayed, but when using the stand alone validator that warning is not displayed: http://screencast.com/t/syLa0GjsZv
Same warning should be displayed when using the stand alone validator.
Reopening bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

3 years ago
See Also: → bug 1203915
(Assignee)

Comment 4

3 years ago
The standalone validator doesn't enforce the sanity checks that are run when submitting an add-on for real. For example, the "Duplicate add-on ID found." message isn't shown either, if you only validate an add-on that re-uses an existing add-on ID.

This is the expected behavior.
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED

Comment 5

3 years ago
Closing this bug based on comment 4.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.