1202216 - Clicking on a desktop notification should switch to the notifying tab

Status: RESOLVED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[[e-mail]]

Port of bug 853972 and bug 960997.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Philip Chee]

> +          if (!event.isTrusted)
> +            return;
Event sent by DispatchChromeEvent() is always trusted isn't it?

http://mxr.mozilla.org/comm-central/source/mozilla/dom/base/nsContentUtils.h?rev=f4ba4b6e7c95&mark=1042-1042#1041

Is there a test for this?

Comment 3

[[e-mail]]

(In reply to Philip Chee from comment #2)
> > +          if (!event.isTrusted)
> > +            return;
> Event sent by DispatchChromeEvent() is always trusted isn't it?

Do you want random content pages to be able to make themselves the current tab?

> Is there a test for this?

Tricky, because notifications use OS system alerts on Linux and Mac OSX.

Comment 4

[Philip Chee]

Luckily I'm using Windows :P

Comment 5

[Philip Chee]

Comment on attachment 8657537 [details] [diff] [review]
Proposed patch

I copied a test from Firefox and managed to get it to run

Comment 6

[Philip Chee]

Attachment: Part 2 Test

Browser Chrome Test Summary
        Passed: 4
        Failed: 0
        Todo: 0

Comment 7

[[e-mail]]

Pushed comm-central changeset fc768b4b5bae.

Comment 8

[Philip Chee]

Comment on attachment 8660104 [details] [diff] [review]
Part 2 Test

Pushed http://hg.mozilla.org/comm-central/rev/553b56db93cb