1202265 - Add tools for catching visual regressions in Hello

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Andrei Oprea [:andreio]]

Attachment: screenshots.py

Need: A way to detect unexpected changes in the interface.

Comment 1

[Andrei Oprea [:andreio]]

TODO: Add a screencast showing how to use the script.

Comment 2

[Andrei Oprea [:andreio]]

Attachment: Add visual regression tool for Loop

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8665955 [details] [diff] [review]
Add visual regression tool for Loop

Review of attachment 8665955 [details] [diff] [review]:
-----------------------------------------------------------------

This generates a lot of obvious false positives for me, possibly because some diffs aren't getting removed, among other things.

That said, this tool is nonetheless extremely useful; it just showed me a bunch of regressions on a small CSS patch that I wasn't expecting to regress anything.

I've a few comments here, which I'll address, and then I'll add some verbiage to the README.md and land it.

::: browser/components/loop/test/visual-regression/README
@@ +1,1 @@
> +# How to use the visual regression tool

If this file is marked README.md, github will do nice things with it, so I'll make that change.

::: browser/components/loop/test/visual-regression/screenshot
@@ +89,5 @@
> +
> +if args.refs:
> +    take_screenshots(refs_location)
> +if args.diffs:
> +    # take_screenshots(newscreenshots_location)

This wants to be uncommented.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Add visual regression tool for Hello

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/88b05c32f367

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Thanks so much for making this happen, Andrei!

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/88b05c32f367