1205455 - the primary desktop fonts should be specified in one place

Status: RESOLVED INCOMPLETE

(Hello (Loop) :: Client, defect, P2)

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Primary Hello desktop fonts should be specified in one place

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Primary Hello desktop fonts should be specified in one place

Comment 3

[David Critchley (:dcritch)]

Comment on attachment 8667502 [details] [diff] [review]
Primary Hello desktop fonts should be specified in one place

Review of attachment 8667502 [details] [diff] [review]:
-----------------------------------------------------------------

r=dcritch with suggested changes

::: browser/components/loop/content/js/panel.jsx
@@ +1043,5 @@
>            detailsButtonLabel: serviceError.error.friendlyDetailsButtonLabel,
>            detailsButtonCallback: serviceError.error.friendlyDetailsButtonCallback
>          });
>        } else {
> +        console.error("removing service error");

As per our discussion, please remove

::: browser/components/loop/ui/ui-showcase.jsx
@@ +1369,5 @@
>            <Section name="RoomFailureView">
>              <FramedExample
>                dashed={true}
>                height={254}
> +              summary="RoomFailureView"

Already applied in previous patch, need to be removed?

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

The newly landed visual regression tool, from bug 1202265, caught multiple regressions in this patch, so it's going to need some more work.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Giving back to nobody, in case somebody else wants to pick it up and run with it.

Comment 6

[Mark Banner (:standard8)]

Support for Hello/Loop has been discontinued.

https://support.mozilla.org/kb/hello-status

Hence closing the old bugs. Thank you for your support.