Closed Bug 1202332 Opened 9 years ago Closed 9 years ago

XiphExtradataToHeaders miscalculates final header length

Categories

(Core :: Audio/Video: Playback, defect)

Product:
Core
Component:
Audio/Video: Playback
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla43
Tracking Flags:
Tracking Status
firefox42 --- fixed
firefox43 --- fixed

People

(Reporter: kinetik, Assigned: kinetik)

References

Details

Attachments

(1 file)

bugX_extradata.patch
555 bytes, patch
derf
: review+
Details | Diff | Splinter Review
For an example file I have on hand, the CodecPrivate element contains 4022 bytes, with 3 headers, and the first two headers are 30 and 81 bytes. XiphExtradataToheaders calculates the final header size as 4019 (4022 - 1 - 1 - 1) rather than 3908 (4022 - 1 - 1 - 1 - 30 - 81). This is caused by XiphExtradataToheaders using aAvailable without subtracting total (the running count of header sizes) as the final header size.
Attachment #8657679 - Flags: review?(tterribe)
Attachment #8657679 - Flags: review?(tterribe) → review+
https://hg.mozilla.org/mozilla-central/rev/391d49ed7ca7
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Blocks: 1197083
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: