1202421 - Please rename the network.auth.allow-subresource-auth pref

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

As mentioned by Felipe ( https://bugzilla.mozilla.org/show_bug.cgi?id=1201065#c3 ) and like bug 1202420, we need to rename the network.auth.allow-subresource-auth pref.
Otherwise, our users will be stuck.
This has to be done before 41 rc (Sept 14th)

Comment 1

[Sylvestre Ledru [:Sylvestre]]

[Tracking Requested - why for this release]:

We don't want to ship without the old pref name.

Dragana, could you take care of that? Thanks

Comment 2

[Dragana Damjanovic [:dragana]]

Attachment: bug_1202421.patch

Comment 3

[Michal Novotny [:michal]]

Comment on attachment 8657848 [details] [diff] [review]
bug_1202421.patch

Review of attachment 8657848 [details] [diff] [review]:
-----------------------------------------------------------------

I guess we need to change the pref name at all places. See http://mxr.mozilla.org/mozilla-central/search?string=allow-subresource-auth

Comment 4

[Sylvestre Ledru [:Sylvestre]]

And the doc too...
:(

Comment 5

[Dragana Damjanovic [:dragana]]

Attachment: bug_1202421.patch

Thanks.
sorry that I forgot all that :)

Comment 6

[Dragana Damjanovic [:dragana]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5501401b840b

Comment 7

[Dragana Damjanovic [:dragana]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4ec440c5693

Comment 8

[Dragana Damjanovic [:dragana]]

Attachment: bug_1202421.patch

fix a typo.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e009d40f03dc

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e009d40f03dc

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e009d40f03dc

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Dragana, do you want to request an uplift to Beta for this one?

Comment 13

[Dragana Damjanovic [:dragana]]

Comment on attachment 8658130 [details] [diff] [review]
bug_1202421.patch

Approval Request Comment
[Feature/regressing bug #]: regression from bug 647010
[User impact if declined]: a hotfox has changed the pref value and this is needed for following releases.
[Describe test coverage new/current, TreeHerder]: It is only renaming a pref
[Risks and why]: low
[String/UUID change made/needed]: none

Comment 14

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8658130 [details] [diff] [review]
bug_1202421.patch

Patch seems safe for uplift to Aurora42 and Beta41.

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/b5df49a0be10

Comment 16

[Kohei Yoshino [:kohei]]

Updated the site compat doc: https://www.fxsitecompat.com/en-US/docs/2015/http-auth-dialog-can-no-longer-be-triggered-by-cross-origin-resources/

Comment 17

[Sylvestre Ledru [:Sylvestre]]

Dragana, this was never uplifted to 42. Any reason why? Could you fill the uplift request to 42? Thanks

Comment 18

[Dragana Damjanovic [:dragana]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #17)
> Dragana, this was never uplifted to 42. Any reason why? Could you fill the
> uplift request to 42? Thanks

There is request filled and also approved for both 42 and 41 (comment 14). I do not know why it has not been uplifted.

I will clean up flags and ask for approval for beta42 again.

Comment 19

[Dragana Damjanovic [:dragana]]

Comment on attachment 8658130 [details] [diff] [review]
bug_1202421.patch

Approval Request Comment
[Feature/regressing bug #]: regression from bug 647010
[User impact if declined]: a hotfox has changed the pref value and this is needed for following releases.
[Describe test coverage new/current, TreeHerder]: It is only renaming a pref
[Risks and why]: low
[String/UUID change made/needed]: none

Comment 20

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8658130 [details] [diff] [review]
bug_1202421.patch

thanks

Comment 21

[Dragana Damjanovic [:dragana]]

putting checkin-needed just to be sure that this one is not missed for uplift, it was missed once already. (I do not remember needing to put checkin-needed for uplift)

Comment 22

[Kartikaya Gupta (email:[e-mail])]

Landed on current beta after some discussion on IRC:

https://hg.mozilla.org/releases/mozilla-beta/rev/f233ba0de1ba

Comment 23

[Mohammad Maruf Islam]

I have reproduced this bug with Firefox Nightly 43.0a1 (Build ID: 20150907030206) on 
windows 8.1 64-bit with the instructions from comment 0.

Verified as fixed with Firefox beta 43.0b7 (Build ID: 20151126120800)

Mozilla/5.0 (Windows NT 6.3; WOW64; rv:43.0) Gecko/20100101 Firefox/43.0