1202480 - Add subdialogs to AccountManager in prefs in tab

Status: RESOLVED WORKSFORME

(Thunderbird :: Account Manager, defect)

Description

[Richard Marti (:Paenglab)]

With the account manager included in the prefs in tab opening the dialogs for the Junk-, Composition-, Addressing- and Return receipt settings lets jump the prefs to the respective panels and makes loosing the focus of the account manager panels. With opening subdialogs the user can set the needed global prefs and with closing the dialog he is back on account manager there he started.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: AM-Subdialogs.patch

This patch opens subdialogs of the Junk-, Composition-, Addressing- and Return receipt settings instead of jumping to the prefs pages and tabs. This helps to not to loose the focus in AM.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: AM-Subdialogs.patch

Updated to tip.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: AM-Subdialogs.patch

My latest patch to make most dialogs in-content.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 8984234 [details] [diff] [review]
AM-Subdialogs.patch

This really depends on bug 1096006, so let's move this first and then come back here. Meanwhile, I'm removing this from my review queue.

Comment 5

[Jorg K (CEST = GMT+2)]

Can we move this forward now that bug 1096006 finally landed.

Comment 6

[Richard Marti (:Paenglab)]

I have a updated patch but need to add some more dialogs.

Comment 7

[Richard Marti (:Paenglab)]

Attachment: 1202480-AM-Subdialogs.patch

Updated patch. Linter is satisfied.

I list the issues I have and ask you to help me to fix them:

• In Server Settings, the Advanced... dialog seems not to apply changes.
• When I open the three dialogs for Global Composing Preferences..., Global Addressing Preferences... and Global Junk Preferences..., I get this error message:
  TypeError: document.getElementById(...) is nullcompose.js:38:10
  <anonymous> chrome://messenger/content/preferences/compose.js:38
  What is wrong? It also doesn't initialize the disabled items correctly.
• In Outgoing Server (SMTP), when I add a server, it is added but not immediately shown in the list. Changing the pane and coming back shows it. Also should the new server be selected in the list when I close the Add dialog. Changing a server does also not update the details in this pane.

Maybe the first and the third issue are because the main pane doesn't wait for the closing of the dialog. Please also check if you find other issue.

I also don't know if the tests pass. Probably they need some adaption.

Comment 8

[Geoff Lankow (:darktrojan)]

Comment on attachment 9073017 [details] [diff] [review]
1202480-AM-Subdialogs.patch

At face value, it looks a lot better. I haven't had time to dig much deeper yet.

(In reply to Richard Marti (:Paenglab) from comment #7)
> * When I open the three dialogs for Global Composing Preferences..., Global Addressing Preferences... and Global Junk Preferences..., I get this error message: 
> TypeError: document.getElementById(...) is nullcompose.js:38:10
>     <anonymous> chrome://messenger/content/preferences/compose.js:38
> What is wrong? It also doesn't initialize the disabled items correctly.

You're running code in a dialog that's meant for the preferences tab itself.

You could have these buttons open the related pane in the existing tab instead of opening a subdialog, although I can see why a subdialog might be better.

From a code point-of-view, I'd look at using the preprocessor instead of having two copies of the XUL code. `compose.inc.xul` already has most of the code for the addressing and composition dialogs, for example.

Comment 9

[Richard Marti (:Paenglab)]

Attachment: 1202480-AM-Subdialogs.patch

I fixed the error message when opening the dialogs through giving them the ID of the pane. I also use preprocessing to create the dialogs.

• On the "Global Addressing Preferences..." dialog the menulists aren't filled. What is the problem here? The other two dialogs looking good.
• The issue with the outgoing Server not updating the list and the Advanced dialog in Server settings not applying the changes are still where.

Comment 10

[Jorg K (CEST = GMT+2)]

Comment on attachment 9073277 [details] [diff] [review]
1202480-AM-Subdialogs.patch

Sadly no longer relevant.

Comment 11

[Richard Marti (:Paenglab)]

Attachment: 1202480-AM-Subdialogs.patch

Updated patch after the html:input type="number" conversion. Only for the record as parts of it could be used in AM in his own tab.

Comment 12

[Richard Marti (:Paenglab)]

This bug is no more needed.