1202627 - Use Kinto.js dbPrefix option to avoid data clashes between accounts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Sync, defect)

Description

[Michiel de Jong [:michielbdejong]]

Since https://github.com/Kinto/kinto.js/issues/119 was fixed in https://github.com/Kinto/kinto.js/pull/111 we can pass the user's email address as a dbPrefix in kinto.js. This will avoid mixing up data of different users.

Comment 1

[Michiel de Jong [:michielbdejong]]

Should also try out https://github.com/Kinto/kinto.js/issues/114#issuecomment-134299911 to see if it's possible to clean up unused databases (although probably we don't want to clean up anything unless there is a reason to believe that local data is corrupt, or if a disk space shortage is detected on the phone's internal storage).

Comment 2

[Michiel de Jong [:michielbdejong]]

Optimization we can do as a part of this bug:
Once we can keep databases of different accounts separate, we can optimize the SyncEngine constructor so that it does not needlessly retrieve meta/global and crypto/keys if local copies of them are already available.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] michielbdejong:1202627-dbPrefix > mozilla-b2g:master

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/33f3aeab5437587cddd5c752d3818868486cc9f0