Closed
Bug 1202870
Opened 8 years ago
Closed 8 years ago
Update browser toolbar menu item row height to 48dp on > GB
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox43 fixed, fennec43+)
RESOLVED
FIXED
Firefox 43
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
Attachments
(2 files)
menu_item_row_height appears to be the dimen we're looking for. Originally brought up with bug 1140169 comment 1. Tracking 43 with bug 1148550.
Assignee | ||
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
Bug 1202870 - Set toolbar menu row height to 48dp. r=mhaigh I tried to use the `?android:attr/...` method listed in the nearby comments but kept receiving a "ResourceNotFound" exception. I wonder if this is related to the way we inherit and then override the themes.
Attachment #8658445 -
Flags: review?(mhaigh)
Assignee | ||
Updated•8 years ago
|
tracking-fennec: --- → 43+
Comment 3•8 years ago
|
||
Comment on attachment 8658445 [details] MozReview Request: Bug 1202870 - Set toolbar menu row height to 48dp. r=mhaigh https://reviewboard.mozilla.org/r/18611/#review16811
Attachment #8658445 -
Flags: review?(mhaigh) → review+
Comment 5•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4c29498bbb5c
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•