Closed Bug 1202870 Opened 5 years ago Closed 5 years ago

Update browser toolbar menu item row height to 48dp on > GB

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 43
Tracking Status
firefox43 --- fixed
fennec 43+ ---

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

Attachments

(2 files)

menu_item_row_height appears to be the dimen we're looking for.

Originally brought up with bug 1140169 comment 1.

Tracking 43 with bug 1148550.
Bug 1202870 - Set toolbar menu row height to 48dp. r=mhaigh

I tried to use the `?android:attr/...` method listed in the nearby comments but
kept receiving a "ResourceNotFound" exception. I wonder if this is related to
the way we inherit and then override the themes.
Attachment #8658445 - Flags: review?(mhaigh)
tracking-fennec: --- → 43+
Comment on attachment 8658445 [details]
MozReview Request: Bug 1202870 - Set toolbar menu row height to 48dp. r=mhaigh

https://reviewboard.mozilla.org/r/18611/#review16811
Attachment #8658445 - Flags: review?(mhaigh) → review+
https://hg.mozilla.org/mozilla-central/rev/4c29498bbb5c
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
You need to log in before you can comment on or make changes to this bug.