KidFox: Restricted profiles - Hide 'Remove' context menu item from Top Sites list

VERIFIED FIXED in Firefox 42

Status

()

defect
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: csuciu, Assigned: sebastian)

Tracking

Trunk
Firefox 43
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 verified, firefox43 verified, fennec42+)

Details

Attachments

(1 attachment)

Reporter

Description

4 years ago
In a restricted profile, the 'Remove' context menu item from Top Sites list should be hidden if the device owner enables 'Disable "Clear browsing history"'.

Similar to # 1196708 which fixed the context menu for the Top Sites grid
Reporter

Updated

4 years ago
Blocks: FFB, kidfox-v1
Assignee: nobody → s.kaspari
Bug 1203011 - Restricted profiles: Hide 'Remove' context menu item from Top Sites list. r?ally
Attachment #8661727 - Flags: review?(ally)
Status: NEW → ASSIGNED
[Tracking Requested - why for this release]: Support for restricted profiles / Project "KidFox" is targeting 43 and this will need to be uplifted.
tracking-fennec: --- → 43+
tracking-fennec: 43+ → 42+
Comment on attachment 8661727 [details]
MozReview Request: Bug 1203011 - Restricted profiles: Hide 'Remove' context menu item from Top Sites list. r?ally

https://reviewboard.mozilla.org/r/19431/#review17643

I'm not sure I agree with this feature, but the patch does what it says on the box.
Attachment #8661727 - Flags: review?(ally) → review+
Comment on attachment 8661727 [details]
MozReview Request: Bug 1203011 - Restricted profiles: Hide 'Remove' context menu item from Top Sites list. r?ally

Approval Request Comment

[Feature/regressing bug #]: Bug 1188905: "KidFox: Restricted profiles - Prevent clearing history". Support for restricted profiles will launch in Fx42.

[User impact if declined]: "Prevent clearing history" feature will be broken: There's still a way to remove websites from the history.

[Describe test coverage new/current, TreeHerder]: Local testing (No UI testing support for restricted profiles yet).

[Risks and why]: Low - just hiding a menu item.

[String/UUID change made/needed]: -
Attachment #8661727 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/9df83a757322
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43

Comment 7

4 years ago
Verified as fixed on latest Nightly
Status: RESOLVED → VERIFIED
Comment on attachment 8661727 [details]
MozReview Request: Bug 1203011 - Restricted profiles: Hide 'Remove' context menu item from Top Sites list. r?ally

Unfortunately this hasn't been uplifted to Aurora(42) in time before merge day. Re-requesting uplift for Beta(42).

(In reply to Sebastian Kaspari (:sebastian) from comment #5)
> Comment on attachment 8661727 [details]
> MozReview Request: Bug 1203011 - Restricted profiles: Hide 'Remove' context
> menu item from Top Sites list. r?ally
> 
> Approval Request Comment
> 
> [Feature/regressing bug #]: Bug 1188905: "KidFox: Restricted profiles -
> Prevent clearing history". Support for restricted profiles will launch in
> Fx42.
> 
> [User impact if declined]: "Prevent clearing history" feature will be
> broken: There's still a way to remove websites from the history.
> 
> [Describe test coverage new/current, TreeHerder]: Local testing (No UI
> testing support for restricted profiles yet).
> 
> [Risks and why]: Low - just hiding a menu item.
> 
> [String/UUID change made/needed]: -
Attachment #8661727 - Flags: approval-mozilla-aurora? → approval-mozilla-beta?
Comment on attachment 8661727 [details]
MozReview Request: Bug 1203011 - Restricted profiles: Hide 'Remove' context menu item from Top Sites list. r?ally

Indeed, it was on purpose, it should be in beta 2.
Attachment #8661727 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 11

4 years ago
Verified as fixed on Firefox 42 Beta 2
You need to log in before you can comment on or make changes to this bug.