1203129 - Different shades of grey on the icons from action bar (GB devices?)

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Flaviu Cos]

Attachment: action bar.png

Environment: 
Device: Samsung Galaxy R (Android 2.3.4);
Build: Nightly 43.0a1 (2015-09-09);

Steps to reproduce:
1. Go to a website (e.g.: en.wikipedia.org/wiki/Mozilla);
2. Long tap on a word in order to select it;
3. Observe the icons from the action bar.

Expected result:
All the icons from the action bar have the same color.

Actual result:
'Select all' and 'Copy' icons have a lighter shade of grey.

Notes:
Please check the attached screenshot.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

The action bar is constructed in JS and I believe eventually touches java so we can probably run DrawableCompat.tint/DrawableUtil over all of the assets before showing the action bar.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Looks like we might be able to use the GeckoActionBar style and android:tint here too: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/values/styles.xml?rev=94a35ea51e6a#727

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Also, it's hard to tell, but it looks like we may not have this problem on > GB devices.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I see the regression. I added drawableTintList to Widget.MenuItemActionBar which GeckoActionBar.Button inherits from (seriously...?):

https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/values/styles.xml?rev=94a35ea51e6a#92

Comment 5

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

It'd be great if we can keep this looking the same as the action bar that appears when users try to copy and paste URLs from the toolbar.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Blocking the regressing bug.

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I updated the GeckoActionBar.Button style, the MenuItemActionBar style, and the MenuItemSecondaryActionBar style and nothing fixed this. I don't know what's going on and it's a small discrepancy so probably not worth spending too much time over.

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Anthony Lam (:antlam) from comment #5)
> It'd be great if we can keep this looking the same as the action bar that
> appears when users try to copy and paste URLs from the toolbar.

fwiw, imo it'd be better to consolidate our action bars and take the opportunity to greatly simplify the action bar code (and please, please, please pick better names).

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Since I don't plan on fixing this soon, moving block to depends on.

Comment 10

[Swarnim]

Hi Michael
I am interested in resolving this bug.May be I can help you.

Comment 11

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Hey Swarnim.

Sure, you can dig into this one! I'll just say that I had trouble fixing it myself so it's a tricky one! Let me know if you'd want to work on something a little simpler. My previous comments should provide some context on how the code is structured.

We'll assign you to the bug once you post a patch.

Comment 12

[Swarnim]

Okay Michael.

Comment 13

[Swarnim]

Hi Michael, I tried but can't able to afford Samsung Galaxy R (Android 2.3.4).

Comment 14

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Swarnim from comment #13)
> Hi Michael, I tried but can't able to afford Samsung Galaxy R (Android
> 2.3.4).

Sorry but I'm not sure I understand. By "can't able to afford" do you mean you can't fix the issue? Would you like me to give you a simpler issue to try to fix?

Comment 15

[Swarnim]

In the description by Flaviu, the device that he mentioned in it.Actually I don't have that device i.e.  Samsung Galaxy R (Android 2.3.4) So how can I work in it.I will be happy to fix simpler issue as I am newbie and want to contribute in Mozilla.

Comment 16

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Swarnim from comment #15)
> In the description by Flaviu, the device that he mentioned in it.Actually I
> don't have that device i.e.  Samsung Galaxy R (Android 2.3.4) So how can I
> work in it.I will be happy to fix simpler issue as I am newbie and want to
> contribute in Mozilla.

You can probably use the emulator, which we support from the command line. That being said, it's unclear how long GB will be sticking around so I'm going to WONTFIX this.

Perhaps you can take a look at bug 1187382 or bug 972734?