Closed
Bug 1203160
Opened 7 years ago
Closed 7 years ago
Turn service workers and fetch interception on in Fennec Nightly
Categories
(Core :: DOM: Service Workers, defect)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(2 files)
794 bytes,
patch
|
nsm
:
review+
|
Details | Diff | Splinter Review |
4.46 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8658775 -
Flags: review?(nsm.nikhil)
Comment on attachment 8658775 [details] [diff] [review] Turn service workers and fetch interception on in Fennec Nightly Review of attachment 8658775 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/app/mobile.js @@ +937,5 @@ > + > +// Enable service workers and fetch interception on Nightly Fennec > +#ifdef NIGHTLY_BUILD > +pref("dom.serviceWorkers.enabled", true); > +pref("dom.serviceWorkers.interception.enabled", true); Could you also enable Push on nightly? Just dom.push.enabled.
Attachment #8658775 -
Flags: review?(nsm.nikhil) → review+
Comment 3•7 years ago
|
||
(In reply to Nikhil Marathe [:nsm] (please needinfo?) from comment #2) > Comment on attachment 8658775 [details] [diff] [review] > Turn service workers and fetch interception on in Fennec Nightly > > Review of attachment 8658775 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: mobile/android/app/mobile.js > @@ +937,5 @@ > > + > > +// Enable service workers and fetch interception on Nightly Fennec > > +#ifdef NIGHTLY_BUILD > > +pref("dom.serviceWorkers.enabled", true); > > +pref("dom.serviceWorkers.interception.enabled", true); > > Could you also enable Push on nightly? Just dom.push.enabled. Push on mobile is not ready. It requires support/integration with Google Cloud Messaging.
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #8658979 -
Flags: review?(amarchesini)
Updated•7 years ago
|
Attachment #8658979 -
Flags: review?(amarchesini) → review+
Assignee | ||
Comment 5•7 years ago
|
||
Yeah, not blocking on push for now...
https://hg.mozilla.org/integration/mozilla-inbound/rev/5019d220cbfc https://hg.mozilla.org/integration/mozilla-inbound/rev/43c7686faffd
Comment 7•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5019d220cbfc https://hg.mozilla.org/mozilla-central/rev/43c7686faffd
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•