1204397 - NIGHTLY vs. !RELEASE mismatch enabling ServiceWorkers on Android

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Phil Ringnalda (:philor)]

Bug 1203160 enabled ServiceWorkers for Fennec #ifdef NIGHTLY_BUILD, which is true if the version number ends in a1, and told the interface tests to expect them to be enabled if !isRelease, and isRelease is true when there is no a in the version number. So on aurora, where the version number ends in a2, they are not enabled but the two interface tests expect them to be enabled, https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a5c1cfcea73&filter-searchStr=android%20mochitest

The merge is September 21st.

Comment 1

[(no longer active)]

Oops, nice catch!  Thanks, philor!

Comment 2

[(no longer active)]

Attachment: Fix the test expectations to expect service workers to be enabled only on Nightly for Fennec

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6abdb99b2b30

Comment 4

[Phil Ringnalda (:philor)]

Maybe I've screwed up the patch to do central-as-aurora, since I haven't been the one to do it for years, but https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8cdb09267b6 still fails with that.

Comment 5

[Phil Ringnalda (:philor)]

Oh, no, that patch is broken, because it changed from saying "not enabled on release" to saying "not enabled on nightly" instead of "not enabled on non-nightly"

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/01cf8bf2f3d7

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Both backed out for bustage: https://treeherder.mozilla.org/logviewer.html#?job_id=14076757&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/165e0853088e

Comment 8

[(no longer active)]

Ah, the logic here is pretty complex.  I think we should look for nonNightlyAndroid, and make these interfaces nonNightlyAndroid: false.  That way they are enabled everywhere except for nonNightlyAndroid, which matches what we are trying to achieve here, I think.  Trying that here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d9fc219c1c3

Comment 9

[(no longer active)]

Looks like I finally got the logic right! <https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a1108b66a9e>

Comment 10

[(no longer active)]

Attachment: Fix the test expectations to expect service workers to be enabled only on Nightly for Fennec

The semantics of the new attributes are as follows:
* nightlyAndroid only takes effect on Android.
* If both nightlyAndroid and android are specified, nightlyAndroid takes
* precedence.

These two rules allow us to check for the current situation.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/65cec42b60fa

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/65cec42b60fa