NIGHTLY vs. !RELEASE mismatch enabling ServiceWorkers on Android

RESOLVED FIXED in Firefox 43



3 years ago
3 years ago


(Reporter: philor, Assigned: Ehsan)


Dependency tree / graph

Firefox Tracking Flags

(firefox43 fixed)



(1 attachment, 1 obsolete attachment)



3 years ago
Bug 1203160 enabled ServiceWorkers for Fennec #ifdef NIGHTLY_BUILD, which is true if the version number ends in a1, and told the interface tests to expect them to be enabled if !isRelease, and isRelease is true when there is no a in the version number. So on aurora, where the version number ends in a2, they are not enabled but the two interface tests expect them to be enabled,

The merge is September 21st.

Comment 1

3 years ago
Oops, nice catch!  Thanks, philor!
Assignee: nobody → ehsan

Comment 2

3 years ago
Created attachment 8660756 [details] [diff] [review]
Fix the test expectations to expect service workers to be enabled only on Nightly for Fennec
Attachment #8660756 - Flags: review?(amarchesini)
Attachment #8660756 - Flags: review?(amarchesini) → review+

Comment 4

3 years ago
Maybe I've screwed up the patch to do central-as-aurora, since I haven't been the one to do it for years, but still fails with that.

Comment 5

3 years ago
Oh, no, that patch is broken, because it changed from saying "not enabled on release" to saying "not enabled on nightly" instead of "not enabled on non-nightly"

Comment 8

3 years ago
Ah, the logic here is pretty complex.  I think we should look for nonNightlyAndroid, and make these interfaces nonNightlyAndroid: false.  That way they are enabled everywhere except for nonNightlyAndroid, which matches what we are trying to achieve here, I think.  Trying that here:
Flags: needinfo?(ehsan)

Comment 9

3 years ago
Looks like I finally got the logic right! <>

Comment 10

3 years ago
Created attachment 8661764 [details] [diff] [review]
Fix the test expectations to expect service workers to be enabled only on Nightly for Fennec

The semantics of the new attributes are as follows:
* nightlyAndroid only takes effect on Android.
* If both nightlyAndroid and android are specified, nightlyAndroid takes
* precedence.

These two rules allow us to check for the current situation.
Attachment #8660756 - Attachment is obsolete: true
Attachment #8661764 - Flags: review?(amarchesini)
Attachment #8661764 - Flags: review?(amarchesini) → review+
Last Resolved: 3 years ago
status-firefox43: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Blocks: 1201717
You need to log in before you can comment on or make changes to this bug.