Closed Bug 1204397 Opened 4 years ago Closed 4 years ago

NIGHTLY vs. !RELEASE mismatch enabling ServiceWorkers on Android

Categories

(Core :: DOM: Service Workers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: philor, Assigned: ehsan)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1203160 enabled ServiceWorkers for Fennec #ifdef NIGHTLY_BUILD, which is true if the version number ends in a1, and told the interface tests to expect them to be enabled if !isRelease, and isRelease is true when there is no a in the version number. So on aurora, where the version number ends in a2, they are not enabled but the two interface tests expect them to be enabled, https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a5c1cfcea73&filter-searchStr=android%20mochitest

The merge is September 21st.
Oops, nice catch!  Thanks, philor!
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #8660756 - Flags: review?(amarchesini) → review+
Maybe I've screwed up the patch to do central-as-aurora, since I haven't been the one to do it for years, but https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8cdb09267b6 still fails with that.
Oh, no, that patch is broken, because it changed from saying "not enabled on release" to saying "not enabled on nightly" instead of "not enabled on non-nightly"
Ah, the logic here is pretty complex.  I think we should look for nonNightlyAndroid, and make these interfaces nonNightlyAndroid: false.  That way they are enabled everywhere except for nonNightlyAndroid, which matches what we are trying to achieve here, I think.  Trying that here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d9fc219c1c3
Flags: needinfo?(ehsan)
Looks like I finally got the logic right! <https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a1108b66a9e>
The semantics of the new attributes are as follows:
* nightlyAndroid only takes effect on Android.
* If both nightlyAndroid and android are specified, nightlyAndroid takes
* precedence.

These two rules allow us to check for the current situation.
Attachment #8660756 - Attachment is obsolete: true
Attachment #8661764 - Flags: review?(amarchesini)
Attachment #8661764 - Flags: review?(amarchesini) → review+
https://hg.mozilla.org/mozilla-central/rev/65cec42b60fa
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.