1203244 - Huge context menu after right click in message [ReferenceError: GetThreadTree is not defined] in mailContextMenus.js

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:43.0) Gecko/20100101 Thunderbird/43.0a1 (Build ID 20150909030202)
Lightning 4.5a1 is installed but disabled.

Steps to reproduce:
* Start Thunderbird with clean profile
* Skip system integration and initial account creation
* Create a Feed account to stop Thunderbird for asking for accounts
* Download and save the .eml file from 
  https://bugzilla.mozilla.org/attachment.cgi?id=8658787&action=edit
* Use File > Open Saved Message to view the message in new window
* Right click into message content

Actual Results:
Context menu is huge with many entries. Error Console shows:

Error: ReferenceError: GetThreadTree is not defined
Source File: chrome://messenger/content/mailContextMenus.js Line: 64

Error: TypeError: gContextMenu is undefined
Source File: chrome://messenger/content/mailContextMenus.js Line: 50

Works in Earlybird 42.0a2 (2015-09-09). Probably regressed by Bug 500610.

Comment 1

[alta88]

Attachment: context.patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 8658850 [details] [diff] [review]
context.patch

Review of attachment 8658850 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/base/content/mailContextMenus.js
@@ +60,5 @@
>      return true;
>  
>    // No menu on grouped header row currently, any command would be an implied
>    // multiselect.
> +  if (gFolderDisplay.tree) {

what's gFolderDisplay.tree?

Comment 3

[alta88]

the same thing as GetThreadTree() and null in a message window.  another global func that can be gotten rid of.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 8658850 [details] [diff] [review]
context.patch

Review of attachment 8658850 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good thx. 
I'll attach an unbitrotted patch.

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: context.patch

Comment 6

[alta88]

thanks.

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: context.patch

Really unbitrotted.

Comment 8

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/3e27b83156b6

Comment 9

[Stefan Sitter [:ssitter]]

Verified fixed using Thunderbird 44.0a1 (20150922030229).

Comment 10

[Stefan Sitter [:ssitter]]

Comment on attachment 8663805 [details] [diff] [review]
context.patch

[Approval Request Comment]
Regression caused by (bug #): bug 500610
User impact if declined: broken context menu
Testing completed (on c-c, etc.): see comment 9
Risk to taking this patch (and alternatives if risky):

Comment 11

[Kent James (:rkent)]

Comment on attachment 8663805 [details] [diff] [review]
context.patch

http://hg.mozilla.org/releases/comm-aurora/rev/ca799fe0e2fe