Closed Bug 1203283 Opened 4 years ago Closed 4 years ago

[AccessFu] Introduce Android "Control" traversal rule

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Besides form controls, it should also navigate to links.
Assignee: nobody → eitan
Comment on attachment 8659476 [details] [diff] [review]
Introduce Android "Control" traversal rule.

Review of attachment 8659476 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, see my comments. Also a traversal test example would be a +.

::: accessible/jsat/Traversal.jsm
@@ +313,5 @@
> +     Roles.SLIDER,
> +     Roles.CHECKBUTTON,
> +     Roles.CHECK_MENU_ITEM,
> +     Roles.SWITCH,
> +     Roles.LINK],

You might also want MENUITEM, and probably OUTLINEITEM (expand/collapse) and ROWHEADER (sorting)

@@ +320,5 @@
> +      // We want to ignore anchors, only focus real links.
> +      if (aAccessible.role == Roles.LINK &&
> +          !Utils.getState(aAccessible).contains(States.LINKED)) {
> +        return Filters.IGNORE;
> +      }

Perhaps also check an action count? AFAIK, if control is disabled it will look as if there are no actions available.
Attachment #8659476 - Flags: review?(yzenevich) → review+
(In reply to Yura Zenevich [:yzen] from comment #2)
> Comment on attachment 8659476 [details] [diff] [review]
> Introduce Android "Control" traversal rule.
> 
> Review of attachment 8659476 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good, see my comments. Also a traversal test example would be a +.
> 
> ::: accessible/jsat/Traversal.jsm
> @@ +313,5 @@
> > +     Roles.SLIDER,
> > +     Roles.CHECKBUTTON,
> > +     Roles.CHECK_MENU_ITEM,
> > +     Roles.SWITCH,
> > +     Roles.LINK],
> 
> You might also want MENUITEM, and probably OUTLINEITEM (expand/collapse) and
> ROWHEADER (sorting)
> 
> @@ +320,5 @@
> > +      // We want to ignore anchors, only focus real links.
> > +      if (aAccessible.role == Roles.LINK &&
> > +          !Utils.getState(aAccessible).contains(States.LINKED)) {
> > +        return Filters.IGNORE;
> > +      }
> 
> Perhaps also check an action count? AFAIK, if control is disabled it will
> look as if there are no actions available.

I don't think we should necessarily skip disabled form controls.
Added test and Role.MENUITEM to rule.
https://hg.mozilla.org/mozilla-central/rev/a2e610b46e85
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.