[AccessFu] Introduce Android "Control" traversal rule

RESOLVED FIXED in Firefox 43

Status

()

Core
Disability Access APIs
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

(Blocks: 1 bug)

unspecified
mozilla43
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
Besides form controls, it should also navigate to links.
(Assignee)

Updated

3 years ago
Blocks: 1182162
(Assignee)

Updated

3 years ago
Assignee: nobody → eitan
(Assignee)

Comment 1

3 years ago
Created attachment 8659476 [details] [diff] [review]
Introduce Android "Control" traversal rule.
Attachment #8659476 - Flags: review?(yzenevich)
Comment on attachment 8659476 [details] [diff] [review]
Introduce Android "Control" traversal rule.

Review of attachment 8659476 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, see my comments. Also a traversal test example would be a +.

::: accessible/jsat/Traversal.jsm
@@ +313,5 @@
> +     Roles.SLIDER,
> +     Roles.CHECKBUTTON,
> +     Roles.CHECK_MENU_ITEM,
> +     Roles.SWITCH,
> +     Roles.LINK],

You might also want MENUITEM, and probably OUTLINEITEM (expand/collapse) and ROWHEADER (sorting)

@@ +320,5 @@
> +      // We want to ignore anchors, only focus real links.
> +      if (aAccessible.role == Roles.LINK &&
> +          !Utils.getState(aAccessible).contains(States.LINKED)) {
> +        return Filters.IGNORE;
> +      }

Perhaps also check an action count? AFAIK, if control is disabled it will look as if there are no actions available.
Attachment #8659476 - Flags: review?(yzenevich) → review+
(Assignee)

Comment 3

3 years ago
(In reply to Yura Zenevich [:yzen] from comment #2)
> Comment on attachment 8659476 [details] [diff] [review]
> Introduce Android "Control" traversal rule.
> 
> Review of attachment 8659476 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good, see my comments. Also a traversal test example would be a +.
> 
> ::: accessible/jsat/Traversal.jsm
> @@ +313,5 @@
> > +     Roles.SLIDER,
> > +     Roles.CHECKBUTTON,
> > +     Roles.CHECK_MENU_ITEM,
> > +     Roles.SWITCH,
> > +     Roles.LINK],
> 
> You might also want MENUITEM, and probably OUTLINEITEM (expand/collapse) and
> ROWHEADER (sorting)
> 
> @@ +320,5 @@
> > +      // We want to ignore anchors, only focus real links.
> > +      if (aAccessible.role == Roles.LINK &&
> > +          !Utils.getState(aAccessible).contains(States.LINKED)) {
> > +        return Filters.IGNORE;
> > +      }
> 
> Perhaps also check an action count? AFAIK, if control is disabled it will
> look as if there are no actions available.

I don't think we should necessarily skip disabled form controls.
(Assignee)

Comment 4

3 years ago
Created attachment 8660841 [details] [diff] [review]
Introduce Android "Control" traversal rule. r=yzen

Added test and Role.MENUITEM to rule.
https://hg.mozilla.org/mozilla-central/rev/a2e610b46e85
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.