1203473 - [Settings] Define AppStorage using new syntax provided by Observable

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

Define the module using new syntax. Details please refer to bug 1178156.

Comment 1

[[e-mail]]

Bug 1178248 looks like a better reference to migrate code

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] gasolin:issue-1203473 > mozilla-b2g:master

Comment 3

[[e-mail]]

Comment on attachment 8660409 [details] [review]
[gaia] gasolin:issue-1203473 > mozilla-b2g:master

please take a look when you have time

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8660409 [details] [review]
[gaia] gasolin:issue-1203473 > mozilla-b2g:master

Hi Fred, the changes look good but the unit tests fail. Flag me once more once they pass again. Thanks

Comment 5

[[e-mail]]

Comment on attachment 8660409 [details] [review]
[gaia] gasolin:issue-1203473 > mozilla-b2g:master

Thanks for point out the test issue. I should wait when treeherder is functional.

Now test green, please kindly review it again.

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8660409 [details] [review]
[gaia] gasolin:issue-1203473 > mozilla-b2g:master

Looks great just a couple of nits.

Comment 7

[[e-mail]]

issue addressed, merged https://github.com/mozilla-b2g/gaia/commit/8bf0d52181e0b369b1ef50a19b6fdd21932ef27e

thanks!