Closed Bug 1203461 Opened 8 years ago Closed 8 years ago

[Settings] USB protocol can only be changed when device unplugged

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:2.5?)

RESOLVED FIXED
blocking-b2g 2.5?

People

(Reporter: gasolin, Assigned: gasolin)

References

Details

Attachments

(2 files, 1 obsolete file)

======== clone from Bug 1194045 comment 12 ===========

Talked with Harly & Eden, the UI spec will be appended to:

* Show same ums description as in root panel to indicate current ums state.
* Disable the protocol selection when:
1. ums enabled & device plugged
2. usm enabled then disabled but device is still plugged


We need refactor MediaVolume related function into module first to serve the device plugged info
in short: show states description and only disable when plugged (and in enable state)
follow up of bug 1194045, including some MediaVolume refactor work
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
blocking-b2g: --- → 2.5?
See Also: → 1203473
Spec based on offline discussion with Fred and Eden.
We have some specific issues on Aries in regards to USB, is this for Flame?
Flags: needinfo?(gasolin)
It's used to prevent issue on Aries (which does not support hot-switch the usb transfer protocol)

If we still want hot-switch for Flame after Bug 1194045 is landed, we need set a device-specific config for flame.
Flags: needinfo?(gasolin)
Depends on: 1205588
Attachment #8662268 - Attachment is obsolete: true
Hey Naoki,  Can you look at this and find a duplicate or block it accordingly?

Thanks
Flags: needinfo?(nhirata.bugzilla)
See Also: → 1206927
Comment on attachment 8664778 [details] [review]
[gaia] gasolin:issue-1203461 > mozilla-b2g:master

Have addressed the UX spec change
* show plug description in sub panel
* makes protocol selection disable rule refer with MediaStorage.volumeState state

Also make the greyed out opacity level from 0.6 to 0.4 to better recognize its disabled.
Attachment #8664778 - Flags: ui-review?(hhsu)
Attachment #8664778 - Flags: review?(yzenevich)
Comment on attachment 8664778 [details] [review]
[gaia] gasolin:issue-1203461 > mozilla-b2g:master

Nice work, thank you Fred :)
Attachment #8664778 - Flags: ui-review?(hhsu) → ui-review+
Comment on attachment 8664778 [details] [review]
[gaia] gasolin:issue-1203461 > mozilla-b2g:master

Overall looks good, just a couple of nits and looks like a Gij test failing:

apps/settings/test/marionette/tests/usb_storage_settings_test.js
(https://treeherder.mozilla.org/logviewer.html#?job_id=2326124&repo=gaia)

Removing the r? for now to address the failure.
Attachment #8664778 - Flags: review?(yzenevich)
Comment on attachment 8664778 [details] [review]
[gaia] gasolin:issue-1203461 > mozilla-b2g:master

Issue addressed, please kindly review it again.
Attachment #8664778 - Flags: review?(yzenevich)
Comment on attachment 8664778 [details] [review]
[gaia] gasolin:issue-1203461 > mozilla-b2g:master

Looks good, Fred, thanks! Just a couple of questions inline.
Attachment #8664778 - Flags: review?(yzenevich) → review+
FYR, in Bug 1206927 comment 6 , UI designer explicit ask for 30% opacity for all disable state

Merged https://github.com/mozilla-b2g/gaia/commit/68a29fb942f1c34a330e5829ef1afeaa659c2838

Thanks!
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: needinfo?(nhirata.bugzilla)
Resolution: --- → FIXED
(In reply to Fred Lin [:gasolin] from comment #15)
> FYR, in Bug 1206927 comment 6 , UI designer explicit ask for 30% opacity for
> all disable state
> 
> Merged
> https://github.com/mozilla-b2g/gaia/commit/
> 68a29fb942f1c34a330e5829ef1afeaa659c2838
> 
> Thanks!

Thanks, yeah, I guess we'd need to update the components at some point :)
Depends on: 1210834
You need to log in before you can comment on or make changes to this bug.