1203461 - [Settings] USB protocol can only be changed when device unplugged

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

======== clone from Bug 1194045 comment 12 ===========

Talked with Harly & Eden, the UI spec will be appended to:

* Show same ums description as in root panel to indicate current ums state.
* Disable the protocol selection when:
1. ums enabled & device plugged
2. usm enabled then disabled but device is still plugged


We need refactor MediaVolume related function into module first to serve the device plugged info

Comment 1

[[e-mail]]

in short: show states description and only disable when plugged (and in enable state)

Comment 2

[[e-mail]]

follow up of bug 1194045, including some MediaVolume refactor work

Comment 3

[Harly Hsu[:harly]]

Attachment: [Settings] USB Transfer Protocol_v1.1.pdf

Spec based on offline discussion with Fred and Eden.

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

We have some specific issues on Aries in regards to USB, is this for Flame?

Comment 5

[[e-mail]]

It's used to prevent issue on Aries (which does not support hot-switch the usb transfer protocol)

If we still want hot-switch for Flame after Bug 1194045 is landed, we need set a device-specific config for flame.

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] gasolin:issue-1205588 > mozilla-b2g:master

Comment 7

[Mahendra Potharaju [:mahe]]

Hey Naoki,  Can you look at this and find a duplicate or block it accordingly?

Thanks

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] gasolin:issue-1203461 > mozilla-b2g:master

Comment 9

[[e-mail]]

Comment on attachment 8664778 [details] [review]
[gaia] gasolin:issue-1203461 > mozilla-b2g:master

Have addressed the UX spec change
* show plug description in sub panel
* makes protocol selection disable rule refer with MediaStorage.volumeState state

Also make the greyed out opacity level from 0.6 to 0.4 to better recognize its disabled.

Comment 10

[Harly Hsu[:harly]]

Comment on attachment 8664778 [details] [review]
[gaia] gasolin:issue-1203461 > mozilla-b2g:master

Nice work, thank you Fred :)

Comment 11

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8664778 [details] [review]
[gaia] gasolin:issue-1203461 > mozilla-b2g:master

Overall looks good, just a couple of nits and looks like a Gij test failing:

apps/settings/test/marionette/tests/usb_storage_settings_test.js
(https://treeherder.mozilla.org/logviewer.html#?job_id=2326124&repo=gaia)

Removing the r? for now to address the failure.

Comment 12

[[e-mail]]

Comment on attachment 8664778 [details] [review]
[gaia] gasolin:issue-1203461 > mozilla-b2g:master

Issue addressed, please kindly review it again.

Comment 13

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8664778 [details] [review]
[gaia] gasolin:issue-1203461 > mozilla-b2g:master

Looks good, Fred, thanks! Just a couple of questions inline.

Comment 15

[[e-mail]]

FYR, in Bug 1206927 comment 6 , UI designer explicit ask for 30% opacity for all disable state

Merged https://github.com/mozilla-b2g/gaia/commit/68a29fb942f1c34a330e5829ef1afeaa659c2838

Thanks!

Comment 16

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Fred Lin [:gasolin] from comment #15)
> FYR, in Bug 1206927 comment 6 , UI designer explicit ask for 30% opacity for
> all disable state
> 
> Merged
> https://github.com/mozilla-b2g/gaia/commit/
> 68a29fb942f1c34a330e5829ef1afeaa659c2838
> 
> Thanks!

Thanks, yeah, I guess we'd need to update the components at some point :)