Location bar should be kept focus after selected the Search suggestions prompt by keyboard access key

RESOLVED FIXED in Firefox 43

Status

()

defect
P2
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: alice0775, Assigned: adw)

Tracking

({polish})

Trunk
Firefox 43
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox43 fixed)

Details

(Whiteboard: [suggestions][fxsearch])

Attachments

(1 attachment, 1 obsolete attachment)

Bug 1192631 has been fixed, but usability is not a GOOD.
Because, Location bar loses focus after selected the Search suggestions prompt by keyboard access key. 


Steps to reproduce:
1. Start Firefox with new profile
2. Focus the location bar.
3. Type anything that will cause suggestions to appear.
4. Observe that the "Would you like to improve your search experience with suggestions?" prompt appears.
5. Select "No" / "Yes" with keyboard access key Alt+N / Alt+Y

Actual Results:
Location bar lost focus.

Expected Results:
Location ar should be kept focus, so that you can type text in location bar continuously
Blocks: 1192631
makes sense, it would be a better experience.
Priority: -- → P2
Whiteboard: [suggestions][fxsearch]
Posted patch patch (obsolete) — Splinter Review
Without the selectTextRange(), the text is automatically selected, which I don't think is a great experience.
Assignee: nobody → adw
Status: NEW → ASSIGNED
Attachment #8660225 - Flags: review?(mak77)
Comment on attachment 8660225 [details] [diff] [review]
patch

Review of attachment 8660225 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/urlbarBindings.xml
@@ +666,5 @@
>                  this._userMadeSearchSuggestionsChoice =
>                    this._prefs.getBoolPref(aData);
> +                this.focus();
> +                this.selectTextRange(this.textValue.length,
> +                                     this.textValue.length);

I think you can set this.mIgnoreFocus = true / false around the focus call?
Attachment #8660225 - Flags: review?(mak77) → feedback+
Posted patch patch v2Splinter Review
Indeed!
Attachment #8660225 - Attachment is obsolete: true
Attachment #8661362 - Flags: review?(mak77)
Attachment #8661362 - Flags: review?(mak77) → review+
Depends on: 1205385
https://hg.mozilla.org/mozilla-central/rev/ece591e2a862
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
I have reproduced this bug on Firefox nightly 43.0a1 according to (2015-9-10)

It's verified on Latest Firefox Beta 
Build ID 	20151123113812
User Agent 	Mozilla/5.0 (Windows NT 6.3; rv:43.0) Gecko/20100101 Firefox/43.0

Tested OS- 32bit windows8.1
QA Whiteboard: [testday-20151127]
You need to log in before you can comment on or make changes to this bug.