1203724 - Location bar should be kept focus after selected the Search suggestions prompt by keyboard access key

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Alice0775 White]

Bug 1192631 has been fixed, but usability is not a GOOD.
Because, Location bar loses focus after selected the Search suggestions prompt by keyboard access key. 


Steps to reproduce:
1. Start Firefox with new profile
2. Focus the location bar.
3. Type anything that will cause suggestions to appear.
4. Observe that the "Would you like to improve your search experience with suggestions?" prompt appears.
5. Select "No" / "Yes" with keyboard access key Alt+N / Alt+Y

Actual Results:
Location bar lost focus.

Expected Results:
Location ar should be kept focus, so that you can type text in location bar continuously

Comment 1

[Marco Bonardo [:mak]]

makes sense, it would be a better experience.

Comment 2

[Drew Willcoxon :adw (Away July 17–July 24)]

Attachment: patch

Without the selectTextRange(), the text is automatically selected, which I don't think is a great experience.

Comment 3

[Marco Bonardo [:mak]]

Comment on attachment 8660225 [details] [diff] [review]
patch

Review of attachment 8660225 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/urlbarBindings.xml
@@ +666,5 @@
>                  this._userMadeSearchSuggestionsChoice =
>                    this._prefs.getBoolPref(aData);
> +                this.focus();
> +                this.selectTextRange(this.textValue.length,
> +                                     this.textValue.length);

I think you can set this.mIgnoreFocus = true / false around the focus call?

Comment 4

[Drew Willcoxon :adw (Away July 17–July 24)]

Attachment: patch v2

Indeed!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/ece591e2a862

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ece591e2a862

Comment 7

[Saheda Reza [:Antora]]

I have reproduced this bug on Firefox nightly 43.0a1 according to (2015-9-10)

It's verified on Latest Firefox Beta 
Build ID 	20151123113812
User Agent 	Mozilla/5.0 (Windows NT 6.3; rv:43.0) Gecko/20100101 Firefox/43.0

Tested OS- 32bit windows8.1