[View Source] View Source cannot find file in Calendar app

VERIFIED FIXED

Status

Firefox OS
Gaia::Calendar
P2
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: njpark, Assigned: gaye)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:2.5+, feature-b2g:2.5+)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

2 years ago
STR:
Turn on View Source, start the calendar app
Enable View source

Expected:
It opens up with Calendar source

Actual:
View source window says it cannot find the file specified.  This seems to be the case anywhere within the calendar app

STR:
Build ID               20150910030223
Gaia Revision          47459eead04385e22f967012b824f5abdddcfb7c
Gaia Date              2015-09-09 10:37:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/dd2a1d737a64d9a3f23714ec5cc623ec8933b51f
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150910.063208
Firmware Date          Thu Sep 10 06:32:18 EDT 2015
Bootloader             L1TC000118D0
(Reporter)

Comment 1

2 years ago
[Blocking Requested - why for this release]:
Nominiating to block since View Source is a 2.5 committed feature, and Calendar is an official app bundled with the build
blocking-b2g: --- → 2.5?
No longer depends on: 1204001
(Reporter)

Comment 2

2 years ago
Could you let me know whether I filed this bug under the correct component?  Thanks!
Flags: needinfo?(drs)
(Reporter)

Updated

2 years ago
Blocks: 1204004
(Reporter)

Updated

2 years ago
No longer blocks: 1204004
Blocks: 1188667

Comment 3

2 years ago
Created attachment 8661033 [details] [review]
[gaia] DouglasSherk:1204002-view-source-calendar > mozilla-b2g:master
Created attachment 8661034 [details] [diff] [review]
Use app `origin` and `launch_path` (for packaged apps) for view-source schema.
Assignee: nobody → drs
Status: NEW → ASSIGNED
Flags: needinfo?(drs)
Comment on attachment 8661033 [details] [review]
[gaia] DouglasSherk:1204002-view-source-calendar > mozilla-b2g:master

This seems a bit shaky to me, but it works in every case that I tried. Fabrice, can you think of a better way to write this?
Attachment #8661033 - Flags: review?(fabrice)
Attachment #8661033 - Flags: review?(etienne)
Comment on attachment 8661033 [details] [review]
[gaia] DouglasSherk:1204002-view-source-calendar > mozilla-b2g:master

I don't know what's returned by appConfig.origin, but that doesn't look like a real origin.
Attachment #8661033 - Flags: review?(fabrice)
Blocks 2.5 with P2 priority.
blocking-b2g: 2.5? → 2.5+
feature-b2g: --- → 2.5+
Priority: -- → P2
Here's a conversation I had with Fabrice about this:
http://logs.glob.uno/?c=mozilla%23fxos&s=15+Sep+2015&e=15+Sep+2015#c536

Fabrice called this out as being a problem with the Calendar app, rather than the View Source feature. Thus, I'm moving this into Calendar and unassigning myself.

Gareth, I'm not sure if you're the right person for this or not, but could you take a look or point the right person to it?
Assignee: drs → nobody
Status: ASSIGNED → NEW
Component: Gaia::System → Gaia::Calendar
Flags: needinfo?(gaye)
Comment on attachment 8661033 [details] [review]
[gaia] DouglasSherk:1204002-view-source-calendar > mozilla-b2g:master

This patch actually worked pretty well, but it was semantically incorrect.
Attachment #8661033 - Attachment is obsolete: true
Attachment #8661033 - Flags: review?(etienne)
(Assignee)

Comment 10

2 years ago
I don't entirely understand from the irc logs what behaviour calendar is expected to have that it doesn't. Can you elaborate on that a bit Fabrice? Our manifest points to the index.html as the launch path and then from there we use a client-side router.
Flags: needinfo?(gaye) → needinfo?(fabrice)
The router is using made-up URLs that have no file backing them.  I think there is already a bug on using #!-style routing to avoid this exact same problem?  Alternately, service-worker magic can make things be real.
Flags: needinfo?(fabrice)
Or rather, the bug was about the non-existent URL being reopened and getting a 404.
(Assignee)

Comment 13

2 years ago
Okay yeah I agree that it would be better if urls worked in calendar. I'm pretty sure that's not going to get fixed this quarter though. We can definitely add it to our backlog though.
Flags: needinfo?(doliver)
Already a blocker, it's on the radar.
Flags: needinfo?(doliver)
Attachment #8661034 - Attachment is obsolete: true

Comment 15

2 years ago
Created attachment 8662592 [details] [review]
[gaia] gaye:1204002-calendar-view-source > mozilla-b2g:master
(Assignee)

Comment 16

2 years ago
Created attachment 8662593 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/31894

Long explanation for what's going on here in patch.
Attachment #8662593 - Flags: review?(jrburke)
Comment on attachment 8662593 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/31894

r+ on inspection, not reviewing the changes in page.js as it is a third party library.
Attachment #8662593 - Flags: review?(jrburke) → review+
(Assignee)

Comment 18

2 years ago
https://github.com/mozilla-b2g/gaia/commit/f13c650f765d0df385f9a7cb0b4bf2eb8b666fe4 landed on master
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Assignee: nobody → gaye
(Reporter)

Comment 19

2 years ago
Verified on Flame:
Build ID               20150921073455
Gaia Revision          2d370fa35c1a0ee2a637e3772c0843586a5f96c9
Gaia Date              2015-09-21 02:41:31
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/039a8490891595736b16a3ccb17f025f4dcf13eb
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150921.112037
Firmware Date          Mon Sep 21 11:20:52 EDT 2015
Bootloader             L1TC000118D0
Status: RESOLVED → VERIFIED

Updated

2 years ago
Depends on: 1209275
You need to log in before you can comment on or make changes to this bug.