1204002 - [View Source] View Source cannot find file in Calendar app

Status: VERIFIED FIXED

Description

[No-Jun Park [:njpark]]

STR:
Turn on View Source, start the calendar app
Enable View source

Expected:
It opens up with Calendar source

Actual:
View source window says it cannot find the file specified.  This seems to be the case anywhere within the calendar app

STR:
Build ID               20150910030223
Gaia Revision          47459eead04385e22f967012b824f5abdddcfb7c
Gaia Date              2015-09-09 10:37:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/dd2a1d737a64d9a3f23714ec5cc623ec8933b51f
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150910.063208
Firmware Date          Thu Sep 10 06:32:18 EDT 2015
Bootloader             L1TC000118D0

Comment 1

[No-Jun Park [:njpark]]

[Blocking Requested - why for this release]:
Nominiating to block since View Source is a 2.5 committed feature, and Calendar is an official app bundled with the build

Comment 2

[No-Jun Park [:njpark]]

Could you let me know whether I filed this bug under the correct component?  Thanks!

Comment 3

[GitHub Autolander Bot]

Created attachment 8661033 [details] [review]
[gaia] DouglasSherk:1204002-view-source-calendar > mozilla-b2g:master

Comment 4

[Doug Sherk (:drs) (inactive)]

Created attachment 8661034 [details] [diff] [review]
Use app `origin` and `launch_path` (for packaged apps) for view-source schema.

Comment 5

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8661033 [details] [review]
[gaia] DouglasSherk:1204002-view-source-calendar > mozilla-b2g:master

This seems a bit shaky to me, but it works in every case that I tried. Fabrice, can you think of a better way to write this?

Comment 6

[[:fabrice] Fabrice Desré]

Comment on attachment 8661033 [details] [review]
[gaia] DouglasSherk:1204002-view-source-calendar > mozilla-b2g:master

I don't know what's returned by appConfig.origin, but that doesn't look like a real origin.

Comment 7

[Mahendra Potharaju [:mahe]]

Blocks 2.5 with P2 priority.

Comment 8

[Doug Sherk (:drs) (inactive)]

Here's a conversation I had with Fabrice about this:
http://logs.glob.uno/?c=mozilla%23fxos&s=15+Sep+2015&e=15+Sep+2015#c536

Fabrice called this out as being a problem with the Calendar app, rather than the View Source feature. Thus, I'm moving this into Calendar and unassigning myself.

Gareth, I'm not sure if you're the right person for this or not, but could you take a look or point the right person to it?

Comment 9

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8661033 [details] [review]
[gaia] DouglasSherk:1204002-view-source-calendar > mozilla-b2g:master

This patch actually worked pretty well, but it was semantically incorrect.

Comment 10

[Gareth Aye [:gaye] (back from PTO)]

I don't entirely understand from the irc logs what behaviour calendar is expected to have that it doesn't. Can you elaborate on that a bit Fabrice? Our manifest points to the index.html as the launch path and then from there we use a client-side router.

Comment 11

[Andrew Sutherland [:asuth]]

The router is using made-up URLs that have no file backing them.  I think there is already a bug on using #!-style routing to avoid this exact same problem?  Alternately, service-worker magic can make things be real.

Comment 12

[Andrew Sutherland [:asuth]]

Or rather, the bug was about the non-existent URL being reopened and getting a 404.

Comment 13

[Gareth Aye [:gaye] (back from PTO)]

Okay yeah I agree that it would be better if urls worked in calendar. I'm pretty sure that's not going to get fixed this quarter though. We can definitely add it to our backlog though.

Comment 14

[Dylan Oliver [:doliver]]

Already a blocker, it's on the radar.

Comment 15

[GitHub Autolander Bot]

Created attachment 8662592 [details] [review]
[gaia] gaye:1204002-calendar-view-source > mozilla-b2g:master

Comment 16

[Gareth Aye [:gaye] (back from PTO)]

Created attachment 8662593 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/31894

Long explanation for what's going on here in patch.

Comment 17

[James Burke [:jrburke]]

Comment on attachment 8662593 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/31894

r+ on inspection, not reviewing the changes in page.js as it is a third party library.

Comment 18

[Gareth Aye [:gaye] (back from PTO)]

https://github.com/mozilla-b2g/gaia/commit/f13c650f765d0df385f9a7cb0b4bf2eb8b666fe4 landed on master

Comment 19

[No-Jun Park [:njpark]]

Verified on Flame:
Build ID               20150921073455
Gaia Revision          2d370fa35c1a0ee2a637e3772c0843586a5f96c9
Gaia Date              2015-09-21 02:41:31
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/039a8490891595736b16a3ccb17f025f4dcf13eb
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150921.112037
Firmware Date          Mon Sep 21 11:20:52 EDT 2015
Bootloader             L1TC000118D0