1204071 - Autophone - runtestsremote.py must explicitly set environment variables via the command line

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

UnitTest.setup_job attempts to set several environment variables for use by the test runner at https://github.com/mozilla/autophone/blob/master/tests/runtestsremote.py#L108

        os.putenv('MINIDUMP_STACKWALK', self.options.minidump_stackwalk)
        os.putenv('MINIDUMP_SAVE_PATH', self.upload_dir)
        os.putenv('MOZ_UPLOAD_DIR', self.upload_dir)

This does not appear to work since the test runners do no inherit their external environment. This results in failures to use minidump_stackwalk to process crash dumps as in:

https://autophone-dev.s3.amazonaws.com/pub/mozilla.org/mobile/tinderbox-builds/mozilla-inbound-android-api-11/1441987007/robocoptest-robocoptests-settings.ini-1-samsung-gs3-3-fea02e71-2bb0-4b94-b736-403cfb2392e3.log

No symbols path given, can't process dump.
MINIDUMP_STACKWALK not set, can't process dump.

I'm not clear yet as to why it says it didn't have symbols_path set as it appears to me that it should be, but I'll continue investigating.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: bug-1204071-v1.patch

Comment 2

[Geoff Brown [:gbrown]]

Comment on attachment 8660456 [details] [diff] [review]
bug-1204071-v1.patch

Review of attachment 8660456 [details] [diff] [review]:
-----------------------------------------------------------------

If you prefer, I think you could use os.environ['var']=value where you had the putenv, but this is fine too.

Is there an issue with the symbols path as well?

Comment 3

[Bob Clary [:bc] (inactive)]

The symbols are already set up for the command line in create_test_args()

Comment 4

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/77f2284242de8db148d9c07512bdc51a8620a552