Make a generic RAII class for pushing and popping sps psuedo frames

RESOLVED FIXED in Firefox 43



JavaScript Engine
2 years ago
2 years ago


(Reporter: fitzgen, Assigned: fitzgen)


Dependency tree / graph

Firefox Tracking Flags

(firefox43 fixed)



(1 attachment)

So that we can add psuedo frames for a bunch of spidermonkey/js stuff.

SPSEntryMarker is close to what we want, but currently is specialized for js::RunScript
Depends on: 1204168
Blocks: 1204169
Blocks: 1074935
Created attachment 8660282 [details] [diff] [review]
Create the js::AutoSPSEntry RAII class for defining psuedo frame entries
Attachment #8660282 - Flags: review?(kvijayan)
Kannan, one issue I have with this patch is that the category doesn't seem to be picked up by the time the devtools get their hands on the samples and the category is always "other". Any ideas why this isn't making it all the way through the pipeline?
The category is getting dropped when the pseudostack entries are recorded into the sample buffer.  See "tools/profiler/core/GeckoSampler.cpp" line 1289.  That file adds a pseudo-stack entry to the sample buffer.

The format of a pseudostack entry on the profile buffer doesn't include the category information.  That formatting needs to be changed to allow for category info to be embedded, then the code above needs to be changed to emit the category info into the profile buffer, and lastly, "tools/profiler/core/ProfileEntry.cpp" line 610 (method ProfileBuffer::StreamSamplesToJSON) needs to be fixed up to parse that and emit the appropriate JSON for it.
If you want, I can take you through that code in more detail over videochat.


2 years ago
Attachment #8660282 - Flags: review?(kvijayan) → review+
Try push:
Blocks: 1204584

Comment 6

2 years ago
Last Resolved: 2 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.