Closed Bug 1204169 Opened 9 years ago Closed 9 years ago

Should always push SPS psuedo frame entries during GC

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla43
Tracking Flags:
Tracking Status
firefox43 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

References

(Blocks 1 open bug)

Details

(Whiteboard: [devtools-platform])

Attachments

(1 file, 3 obsolete files)

Push SPS pseudo frame entries when GCing
2.52 KB, patch
fitzgen
: review+
Details | Diff | Splinter Review
Right now there are a few[0] places that push gc psuedo frames from various dom gc triggers, but we should just always push psuedo frames when gcing. [0] https://dxr.mozilla.org/mozilla-central/search?q=js%3A%3AProfileEntry%3A%3ACategory%3A%3AGC&redirect=true&case=false&limit=87&offset=0
Attachment #8660283 - Flags: review?(terrence)
Comment on attachment 8660283 [details] [diff] [review] Push SPS psuedo frame entries when GCing Review of attachment 8660283 [details] [diff] [review]: ----------------------------------------------------------------- Actually, I think this belongs in AutoTraceSession.
Attachment #8660283 - Flags: review?(terrence)
Attachment #8660283 - Attachment is obsolete: true
Attachment #8660885 - Flags: review?(terrence)
Attachment #8660885 - Attachment is obsolete: true
Attachment #8660885 - Flags: review?(terrence)
Attachment #8660886 - Flags: review?(terrence)
Comment on attachment 8660886 [details] [diff] [review] Push SPS psuedo frame entries when GCing Review of attachment 8660886 [details] [diff] [review]: ----------------------------------------------------------------- Great! That's infinitely better.
Attachment #8660886 - Flags: review?(terrence) → review+
Hi, this failed to apply: adding 1204169 to series file renamed 1204169 -> Bug-1204169---Push-SPS-psuedo-frame-entries-when-G.patch applying Bug-1204169---Push-SPS-psuedo-frame-entries-when-G.patch patching file js/src/gc/GCInternals.h Hunk #1 FAILED at 50 1 out of 1 hunks FAILED -- saving rejects to file js/src/gc/GCInternals.h.rej patch failed, unable to continue (try -v) patch failed, rejects left in working directory errors during apply, please fix and refresh Bug-1204169---Push-SPS-psuedo-frame-entries-when-G.patch could you take a look, thanks!
Flags: needinfo?(nfitzgerald)
Keywords: checkin-needed
See Also: → 1205782
https://hg.mozilla.org/mozilla-central/rev/d501062f060d
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: