1204385 - Add SSL information to Control Center doorhanger

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Kevin Grandon :kgrandon]

We should add some SSL information to the pin dialog.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1204385_pin_dialog_ssl_info > mozilla-b2g:master

Comment 2

[Tiffanie Shakespeare [:tif]]

Hey Matej - can you review a bunch of strings?
https://docs.google.com/a/mozilla.com/spreadsheets/d/1-CCWP6PZd3e2OP_zXYiN01UXtgD6X5DoActCMhQFTW8/edit?usp=sharing

You should be able to make comments. I know this document covers more than just SSL (as per this bug) but all the pages need to be reviewed and we don't have bugs for all the features yet.

I've included screenshots and links to the spec on each page. Please don't hesitate to ask for a meeting - I know there's a lot :)

Thanks so much!!

Comment 3

[Matej Novak [:matej]]

Sure thing. What's the timing on this? I likely won't be able to look until tomorrow or Monday. Does that work?

Comment 4

[Tiffanie Shakespeare [:tif]]

Tomorrow would be ideal but we will live if it doesn't happen until Monday :) Thanks Matej!

Comment 5

[Matej Novak [:matej]]

Hi Tiffanie,

I've gone through and added a bunch comments. If the same comment applied to multiple strings I didn't always repeat it throughout. Hopefully everything is clear, but please let me know if not.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Should we be doing the same for desktop Firefox? I didn't see this anywhere in the desktop Firefox design docs listed at https://wiki.mozilla.org/QA/Control_Center nor in the open bugs remaining.

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #6)
> Should we be doing the same for desktop Firefox? I didn't see this anywhere
> in the desktop Firefox design docs listed at
> https://wiki.mozilla.org/QA/Control_Center nor in the open bugs remaining.

Sorry, I can't figure out what this bug is adding that desktop doesn't have? We do show whether the connection is "secure" or "not secure". Is there anything else I'm missing?

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Sorry, I was referred here by https://www.reddit.com/r/firefox/comments/3hfwpp/any_plans_for_more_information_in_control_center/ and mistakenly thought that this bug was introducing that information as well.

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

I'd love to expose this kind of information but we don't have any mockups for that afaik.

Comment 10

[Tiffanie Shakespeare [:tif]]

Hey guys! 

Right now we don't show SSL information on FirefoxOS so our first step is going to be adding that in (this bug). If you guys think that more information (such as what is mentioned on reddit) would be helpful to show on FirefoxOS, it would be awesome if you could open a separate bug for it. 

As of now, we have only worked on designs for SSL - please see the spec link in the User Story.

Thanks!

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

I don't think we need to go out of our way to show much of what was requested on Reddit as it is very expert-user focused. Calling out weak encryption algorithms should be sufficient for this top-level view. We could possibly provide a HSTS "stamp" and things like that if we felt that it would help users know that this site can't be MITM'd easily.

Comment 12

[Tiffanie Shakespeare [:tif]]

I was checking out the Pin the Web doorhanger and see there is some SSL info already there. Do we know who developed this? We need to figure out a plan to get that implementation updated to match spec (or have a scope reduction conversation).

NI to a few people hunting for who worked on that.

Comment 13

[Kevin Grandon :kgrandon]

This needs to be re-done, and probably filed as a new bug as well. This won't be too useful as-is unfortunately.