1204427 - [Browser] Do not show default icon on pin site badge if no icon provided by the site

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect, P2)

Description

[Alison Shiue]

Attachment: pin_site_badge_no_default_icon.png

STR:
1. Go to http://mozilla-twqa.github.io/QA-Dashboard/ where do not provide site icons
2. Tap site icon on URL bar to check the pin site badge


Expected result:
1. Default pin icon would show on pin site badge


Actual result:
1. No site icon shows on pin site badge, otherwise, the pin site badge would use previous site icon if user navigate to current site from other site. Please refer: https://youtu.be/7we4WFc9sYM


Build info:
[Flame]
Build ID           	20150913150208
Gaia Revision      	4d9b996be4b1935651057d0651461c1a36d98a18
Gaia Date          	2015-09-13 10:47:32
Gecko Revision     	https://hg.mozilla.org/mozilla-central/rev/9ed17db42e3e46f1c712e4dffd62d54e915e0fac
Gecko Version      	43.0a1
Device Name        	flame
Firmware(Release)  	4.4.2
Firmware(Incremental)  eng.cltbld.20150913.184300
Firmware Date      	Sun Sep 13 18:43:14 EDT 2015
Bootloader         	L1TC000118D0

[Aries]
Build ID           	20150913195924
Gaia Revision      	4d9b996be4b1935651057d0651461c1a36d98a18
Gaia Date          	2015-09-13 10:47:32
Gecko Revision     	https://hg.mozilla.org/mozilla-central/rev/9ed17db42e3e46f1c712e4dffd62d54e915e0fac
Gecko Version      	43.0a1
Device Name        	aries
Firmware(Release)  	4.4.2
Firmware(Incremental)  eng.worker.20150913.192006
Firmware Date      	Sun Sep 13 19:20:14 UTC 2015
Bootloader         	s1

Comment 1

[Alison Shiue]

[Blocking Requested - why for this release]:
Obvious problem, moreover, the pin site badge would show previous site icon if the browser window have ever opened other site which has provided site icon

Comment 2

[Gregor Wagner [:gwagner]]

Blocking the feature bug for now.

Comment 3

[Alberto Pastor [:albertopq]]

This behavior has changed since bug 1198246. Can we verify if this is still an issue? Thanks!

Comment 4

[Alison Shiue]

Hi Alberto,

I tried with the latest build on both flame and aries, the difault icon still not show.
Besides, the pin site badge would show previous site icon if the browser window have ever opened other site which has provided site icon.

Build info:
[Flame]
Build ID               20151004150211
Gaia Revision          f3d9981dccfa4dfdfcb865d95fdcfb85e4077e1e
Gaia Date              2015-10-02 13:52:20
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/3d7532ce81ac571962abc3b99582fe7f5d685192
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151004.182636
Firmware Date          Sun Oct  4 18:26:48 EDT 2015
Bootloader             L1TC000118D0

[Aries]
Build ID               20151004181256
Gaia Revision          f3d9981dccfa4dfdfcb865d95fdcfb85e4077e1e
Gaia Date              2015-10-02 13:52:20
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/3d7532ce81ac571962abc3b99582fe7f5d685192
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151004.173222
Firmware Date          Sun Oct  4 17:32:29 UTC 2015
Bootloader             s1

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1204427-previous-icon > mozilla-b2g:master

Comment 6

[Alberto Pastor [:albertopq]]

Comment on attachment 8670786 [details] [review]
[gaia] albertopq:1204427-previous-icon > mozilla-b2g:master

Michael, could you please take a look to this? Thanks!

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Alberto, do we still need this now that pinning-the-web is being removed from the doorhanger? IE. does the context menu for pinning the web use any of the state from app_chrome? If not, let's close this as invalid.

Comment 8

[Alberto Pastor [:albertopq]]

I guess you are right that is going to be removed, but is something that is not working now and we have a simple and ready patch. I would merge it anyway to make it work until the new doorhanger is in place, but happy to close it if you want. If we are not having doorhanger at all in 2.5, then let's just close it. Both ways work for me!

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8670786 [details] [review]
[gaia] albertopq:1204427-previous-icon > mozilla-b2g:master

WFM :)

Comment 10

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/1dd0b1f757986352597b191d08a12dea26a0866f