Closed Bug 1204519 Opened 9 years ago Closed 9 years ago

[TSF][TS_E_NOLAYOUT] Get rid of the hack for TS_E_NOLAYOUT issue with Google Japanese Input

Categories

(Core :: Widget: Win32, defect)

Product:
Core
Component:
Widget: Win32
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla43
Tracking Flags:
Tracking Status
firefox43 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

(Keywords: inputmethod)

Attachments

(2 files)

part.1 Remove hack for TS_E_NOLAYOUT issue of Google Japanese Input
9.30 KB, patch
emk
: review+
Details | Diff | Splinter Review
part.2 Remove TSFStaticSink::IsGoogleJapaneseInputActive()
1.26 KB, patch
emk
: review+
Details | Diff | Splinter Review
Google Japanese Input has been updated. We guess that that includes the fix of TS_E_NOLAYOUT issue. If so, we should remove the hack from our code if it's possible.
As far as I tested, we can remove the hacks. I'll work on this after bug 1204523 since the hack might be usable in the bug.
Summary: [TSF] Investigate if the hack for Google Japanese Input is still necessary → [TSF] Get rid of the hack for TS_E_NOLAYOUT issue with Google Japanese Input
Attachment #8662285 - Flags: review?(VYV03354) → review+
Attachment #8662287 - Flags: review?(VYV03354) → review+
https://hg.mozilla.org/mozilla-central/rev/999f7f57a541 https://hg.mozilla.org/mozilla-central/rev/f5311a0eda9b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Summary: [TSF] Get rid of the hack for TS_E_NOLAYOUT issue with Google Japanese Input → [TSF][TS_E_NOLAYOUT] Get rid of the hack for TS_E_NOLAYOUT issue with Google Japanese Input
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: