Closed
Bug 1204542
Opened 9 years ago
Closed 9 years ago
PBMode tabs should not appear under Synced tabs and should not sync with desktop
Categories
(Firefox for iOS :: Sync, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios-v1.0 | --- | unaffected |
| fxios-v1.1 | --- | affected |
| fxios-v1.0.5 | --- | unaffected |
| fxios | 1.1+ | --- |
People
(Reporter: sleroux, Assigned: fluffyemily)
References
Details
Attachments
(1 file, 1 obsolete file)
Need to make sure that any PBMode tabs do not appear under sync or are available to desktop/any other clients.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → etoop
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8663751 -
Flags: review?(sleroux)
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8663751 [details] [review] Pull request Looks good. Could we get a small test case that shows that the tabs won't be saved?
Attachment #8663751 -
Flags: review?(sleroux) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
In order to make TabManager testable I've had to make a couple of changes to the accessors for some functions. Just would like you to run your eye over it.
Attachment #8663751 -
Attachment is obsolete: true
Attachment #8665388 -
Flags: review?(sleroux)
|
|
Reporter | |
Comment 4•9 years ago
|
||
Comment on attachment 8665388 [details] [review] Pull request Nice test case - just a nit about not needing the internal keyword.
Attachment #8665388 -
Flags: review?(sleroux) → review+
|
|
Assignee | |
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•