Closed Bug 1204851 Opened 4 years ago Closed 4 years ago

Hide tabs tray back button behind nightly flag

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 43
Tracking Status
firefox42 --- unaffected
firefox43 + fixed
firefox44 + fixed

People

(Reporter: mhaigh, Assigned: mhaigh)

References

Details

Attachments

(2 files)

Bug 1200619 introduced the back button for mobile, we should hide this behind a nightly flag until the new tabs tray work is ready to ship
Summary: Hide mobile back button behind nightly flag → Hide tabs tray back button behind nightly flag
Bug 1204851 - Revert back button removal; r?mfinkle
Attachment #8661194 - Flags: review?(mark.finkle)
Bug 1204851 - reinstate changes behind nightly flag; r?mfinkle
Attachment #8661195 - Flags: review?(mark.finkle)
Blocks: 1204876
Comment on attachment 8661194 [details]
MozReview Request: Bug 1204851 - Revert back button removal; r?mfinkle

https://reviewboard.mozilla.org/r/19303/#review17239
Attachment #8661194 - Flags: review?(mark.finkle) → review+
Attachment #8661195 - Flags: review?(mark.finkle) → review+
Comment on attachment 8661195 [details]
MozReview Request: Bug 1204851 - reinstate changes behind nightly flag; r?mfinkle

https://reviewboard.mozilla.org/r/19305/#review17241
Blocks: tabs-tray
No longer blocks: 1204876
Blocks: 1204876
No longer blocks: tabs-tray
Martyn, from https://bugzilla.mozilla.org/show_bug.cgi?id=1207576#c2,  does this need uplift to 43 aurora?  Please reopen and nominate for uplift, if you think this should happen. Thanks!
Flags: needinfo?(mhaigh)
Comment on attachment 8661194 [details]
MozReview Request: Bug 1204851 - Revert back button removal; r?mfinkle

Approval Request Comment
[Feature/regressing bug #]: 1207576
[User impact if declined]: possible crash in the tabs tray
[Describe test coverage new/current, TreeHerder]: try and has been on nightly for a while
[Risks and why]: With both these changes we revert some earlier work and hide behind a nightly flag, there's little risk as we're essentially backing out a previous change and then adding a flag to only modify behaviour on nightly
[String/UUID change made/needed]: N/A
Flags: needinfo?(mhaigh)
Attachment #8661194 - Flags: approval-mozilla-aurora?
Comment on attachment 8661195 [details]
MozReview Request: Bug 1204851 - reinstate changes behind nightly flag; r?mfinkle

Approval Request Comment
[Feature/regressing bug #]: 1207576
[User impact if declined]: possible crash in the tabs tray
[Describe test coverage new/current, TreeHerder]: try and has been on nightly for a while
[Risks and why]: With both these changes we revert some earlier work and hide behind a nightly flag, there's little risk as we're essentially backing out a previous change and then adding a flag to only modify behaviour on nightly
[String/UUID change made/needed]: N/A
Attachment #8661195 - Flags: approval-mozilla-aurora?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8661194 [details]
MozReview Request: Bug 1204851 - Revert back button removal; r?mfinkle

Approved for uplift to aurora.
Attachment #8661194 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8661195 [details]
MozReview Request: Bug 1204851 - reinstate changes behind nightly flag; r?mfinkle

part 2 of aurora uplift.
Attachment #8661195 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
This would be good to verify in aurora once it lands - just to make sure it behaves as expected.
Flags: qe-verify+
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #13)
> This would be good to verify in aurora once it lands - just to make sure it
> behaves as expected.

Yes, this is hidden in Aurora.
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Weird because this doesn't seem to have actually landed in aurora. KWierso can you take a look? Did this land but the bugzilla comment saying so never showed up?
Flags: needinfo?(wkocher)
So, looking at the commits themselves, they have timestamps for September 15, which was while 43 was still on trunk. So these rode the merge down to Aurora already. 

Adjusting flags to what seems to be correct.
Flags: needinfo?(wkocher)
Target Milestone: Firefox 44 → Firefox 43
Hi Liz,

Is the qe-verify+ flag still valid?

Thank you!
Flags: needinfo?(lhenry)
No, we don't need to verify, this train left the station 3 years ago. :)  Thanks!
Flags: qe-verify-
Flags: qe-verify+
Flags: needinfo?(lhenry)
You need to log in before you can comment on or make changes to this bug.