1204851 - Hide tabs tray back button behind nightly flag

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martyn Haigh (:mhaigh)]

Bug 1200619 introduced the back button for mobile, we should hide this behind a nightly flag until the new tabs tray work is ready to ship

Comment 1

[Martyn Haigh (:mhaigh)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=026e369040ee

Comment 2

[Martyn Haigh (:mhaigh)]

Attachment: MozReview Request: Bug 1204851 - Revert back button removal; r?mfinkle

Bug 1204851 - Revert back button removal; r?mfinkle

Comment 3

[Martyn Haigh (:mhaigh)]

Attachment: MozReview Request: Bug 1204851 - reinstate changes behind nightly flag; r?mfinkle

Bug 1204851 - reinstate changes behind nightly flag; r?mfinkle

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8661194 [details]
MozReview Request: Bug 1204851 - Revert back button removal; r?mfinkle

https://reviewboard.mozilla.org/r/19303/#review17239

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8661195 [details]
MozReview Request: Bug 1204851 - reinstate changes behind nightly flag; r?mfinkle

https://reviewboard.mozilla.org/r/19305/#review17241

Comment 6

[Martyn Haigh (:mhaigh)]

https://hg.mozilla.org/integration/fx-team/rev/4d65eea8ab2a4fc5ef9ce57c8e9449efd7e98e04
Bug 1204851 - Revert back button removal; r=mfinkle

https://hg.mozilla.org/integration/fx-team/rev/6e523055b418c0c81d13d281ccd8a6014ae8d3f2
Bug 1204851 - reinstate changes behind nightly flag; r=mfinkle

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4d65eea8ab2a
https://hg.mozilla.org/mozilla-central/rev/6e523055b418

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Martyn, from https://bugzilla.mozilla.org/show_bug.cgi?id=1207576#c2,  does this need uplift to 43 aurora?  Please reopen and nominate for uplift, if you think this should happen. Thanks!

Comment 9

[Martyn Haigh (:mhaigh)]

Comment on attachment 8661194 [details]
MozReview Request: Bug 1204851 - Revert back button removal; r?mfinkle

Approval Request Comment
[Feature/regressing bug #]: 1207576
[User impact if declined]: possible crash in the tabs tray
[Describe test coverage new/current, TreeHerder]: try and has been on nightly for a while
[Risks and why]: With both these changes we revert some earlier work and hide behind a nightly flag, there's little risk as we're essentially backing out a previous change and then adding a flag to only modify behaviour on nightly
[String/UUID change made/needed]: N/A

Comment 10

[Martyn Haigh (:mhaigh)]

Comment on attachment 8661195 [details]
MozReview Request: Bug 1204851 - reinstate changes behind nightly flag; r?mfinkle

Approval Request Comment
[Feature/regressing bug #]: 1207576
[User impact if declined]: possible crash in the tabs tray
[Describe test coverage new/current, TreeHerder]: try and has been on nightly for a while
[Risks and why]: With both these changes we revert some earlier work and hide behind a nightly flag, there's little risk as we're essentially backing out a previous change and then adding a flag to only modify behaviour on nightly
[String/UUID change made/needed]: N/A

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8661194 [details]
MozReview Request: Bug 1204851 - Revert back button removal; r?mfinkle

Approved for uplift to aurora.

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8661195 [details]
MozReview Request: Bug 1204851 - reinstate changes behind nightly flag; r?mfinkle

part 2 of aurora uplift.

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

This would be good to verify in aurora once it lands - just to make sure it behaves as expected.

Comment 14

[:Margaret Leibovic]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #13)
> This would be good to verify in aurora once it lands - just to make sure it
> behaves as expected.

Yes, this is hidden in Aurora.

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Weird because this doesn't seem to have actually landed in aurora. KWierso can you take a look? Did this land but the bugzilla comment saying so never showed up?

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

So, looking at the commits themselves, they have timestamps for September 15, which was while 43 was still on trunk. So these rode the merge down to Aurora already. 

Adjusting flags to what seems to be correct.

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/62a2e70914d5
https://hg.mozilla.org/releases/mozilla-aurora/rev/e4d519b591dd

Comment 18

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b70dc44d745a

Comment 19

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b70dc44d745a

Comment 20

[miralobontiu]

Hi Liz,

Is the qe-verify+ flag still valid?

Thank you!

Comment 21

[Liz Henry (:lizzard) (relman/hg->git project)]

No, we don't need to verify, this train left the station 3 years ago. :)  Thanks!