1200619 - Implement back button to mobile tabs tray

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martyn Haigh (:mhaigh)]

Since we switched to the tablet tabs tray on mobile, we should think about whether we should also implement the back button in the top left of the tabs tray to keep parity with tablet

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Can we get a build? I think this makes sense. Top left has become pretty synonymous with "Back" across applications even across iOS and Android.

Comment 2

[Martyn Haigh (:mhaigh)]

try this: https://dl.dropboxusercontent.com/u/7163922/Work/1200619.apk

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

I like it!

Comment 4

[Barbara Bermes [:barbara] - NI please!]

I like that too! The only thing I'm worried about is do we use this back button consistently enough for other screen where a back would be beneficial? where else do/should we be using the back button?


Also, wouldn't I just use my native OS back button on Android?

Comment 5

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

We currently use it in Settings so it makes sense. This is also very much in alignment with googles new design specs and our iOS cousins.

NI-ing martyn since we want to move forward with this.

Comment 6

[Martyn Haigh (:mhaigh)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=903e2981f62c

Comment 7

[Martyn Haigh (:mhaigh)]

Attachment: MozReview Request: Bug 1200619 - Implement back button to mobile tabs tray; r?mcomella

Bug 1200619 - Implement back button to mobile tabs tray; r?mcomella

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8659906 [details]
MozReview Request: Bug 1200619 - Implement back button to mobile tabs tray; r?mcomella

https://reviewboard.mozilla.org/r/19033/#review16957

Comment 10

[Martyn Haigh (:mhaigh)]

https://hg.mozilla.org/integration/fx-team/rev/2aa3e68dec24086d678c2e544685f4b73bec6afd
Bug 1200619 - Implement back button to mobile tabs tray; r=mcomella

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2aa3e68dec24

Comment 12

[Martyn Haigh (:mhaigh)]

Bug 1204851 hides this fix behind a nightly flag.  This will be removed one the new tab panel work goes live