1205209 - [RTSP]When user connects a special RTSP link, the crash will happen.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: RTSP, defect)

Description

[SandKing]

Attachment: Bug log: logcat_1120.txt

[1.Description]:
[Aries KK v2.5][Flame v2.5]The crash happened on RTSP streaming.
While device  opens a special RTSP URL, the will crash happen.
Here are the detail information:
 -Title
   ~B2G 43.0a1 Crash Report [@ pthread_mutex_lock_impl | libmozglue.so@0x2c449 ]
 -Crash report
  ~https://crash-stats.mozilla.com/report/index/56e581a9-03b8-4902-bdfe-572bc2150916

See log:"logcat_1120.txt"
See video: "Aries_v2.5.3GP"

[2.Testing Steps]: 
1. Connect a network in "Settings".
2. Open Browser and go to "rtsp://184.72.239.149/vod/mp4:BigBuckBunny_175k.mov".
3. Wait for the page to load completely.

[3.Expected Result]: 
3. The page should load completely.

[4.Actual Result]: 
3. The crash will happen.

[5.Reproduction build]: 
Device: Flame KK v2.5 (Affected)
Build ID               20150915150223
Gaia Revision          d2e5c49440bf8410ae747b15c0dd11c54053ef3e
Gaia Date              2015-09-15 07:18:10
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/5d61714cf5c3ec2440e9491ba30893ac37ca06c2
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150915.182947
Firmware Date          Tue Sep 15 18:29:57 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK v2.5 (Affected)
Build ID               20150916005824
Gaia Revision          994ff1537c2d7ca4d1658806c50f3ceba1053f9b
Gaia Date              2015-09-15 12:54:59
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/bd52dfa335821853c69c2fa559edf3e59d55c6f5
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150916.001741
Firmware Date          Wed Sep 16 00:17:49 UTC 2015
Bootloader             s1

Device: Flame KK 2.2 (Unaffected) 
Build ID               20150915032502
Gaia Revision          7a427e0f8aa6c185a9e22358006b97c19435ca4a
Gaia Date              2015-09-09 13:06:12
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/0d9c46d01861
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150915.065222
Firmware Date          Tue Sep 15 06:52:33 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0
[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
12921

Comment 1

[SandKing]

Attachment: Bug video: Aries_v2.5.3GP

Comment 2

[Norry.L.F(Leave from Mozilla)]

[Blocking Requested - why for this release]:
Nominate. It is a 100% crash&regression bug.

Hi No-jun,

Could you help to dispatch this bug? thanks. :)

Comment 3

[No-Jun Park [:njpark]]

Hmm, not exactly sure who would know more aobut this, since I'm not even sure what RTSP is.  Naoki, could you help out with this bug please?

Comment 4

[William Hsu [:whsu]]

Hi, Ethan,

Could you help me assign this bug to developer?
Thank you.

Comment 5

[Ethan Tseng [:ethan]]

Jonathan,
This is a regression and critical bug. Please help to investigate it.

Comment 6

[Ethan Tseng [:ethan]]

The RTSP link (BigBuckBunny) in comment 0 is a basic test case. If we can reproduce this bug, we should mark it as 2.5+.

Comment 7

[Jonathan Hao (inactive) [:jhao]]

I can reproduce this bug on Flame-kk.

Comment 8

[Mahendra Potharaju [:mahe]]

Blocks 2.5. Ethan in Triage meeting says the fix will be coming in this week.

Comment 9

[Jonathan Hao (inactive) [:jhao]]

Attachment: bug-1205209-fix.patch

RtspOmxReader overwrites the function that initializes mStreamSource,
so we need to check if mStreamSource is null before using it.

Hi Benjamin,
Could you review this patch? It should fix RTSP.

Comment 10

[Ethan Tseng [:ethan]]

=== Note ===
The assertion which causes the RTSP crash was added in bug 1190238 (Remove MediaResource::Read/Seek/Tell API).
This bug reminds us again we have to add automation test for RTSP to avoid such regression in the future. Jonathan, we should try to make it happen in 2.5 if possible (Bug 1032111 - [RTSP] Basic RTSP test case on ICS emulator).

Comment 11

[Jean-Yves Avenard [:jya]]

Sorry for causing the regression.

The original behaviour was to query the decoder's resource Tell(). Which for RtspMediaResource always returned 0.

So the patch provided will work.

But are their any other OMX readers not setting mStreamSource and that could return a position in the stream != 0 ?

Comment 12

[Benjamin Chen [:bechen]]

Comment on attachment 8670588 [details] [diff] [review]
bug-1205209-fix.patch

Review of attachment 8670588 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, the fix is simple.

Comment 13

[Jonathan Hao (inactive) [:jhao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c16292a575d6

Comment 14

[Jonathan Hao (inactive) [:jhao]]

> But are their any other OMX readers not setting mStreamSource and that could
> return a position in the stream != 0 ?

As far as I know, RtspOmxReader is the only class inheriting MediaOmxReader

Comment 15

[Jonathan Hao (inactive) [:jhao]]

Attachment: Check whether mStreamSource is null in MediaOmxReader

add r=bechen to patch summary

Comment 16

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/55f6d8363666

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/55f6d8363666

Comment 18

[Ethan Tseng [:ethan]]

Jonathan and Benjamin,
Thank you for fixing this bug! Good job! ^o^

Comment 19

[SandKing]

This bug has been verified as pass on latest Flame v2.5 and Aries KK v2.5.
Same STR as comment 0
Reproduce Rate: 0/10

Flame 2.5(pass):
Build ID               20151009150221
Gaia Revision          1609aecaba381c14eff95d5084e59280f53b7d8b
Gaia Date              2015-10-09 07:16:19
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/c00e93135684441d065791f4f98a338b872d0420
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151009.183801
Firmware Date          Fri Oct  9 18:38:15 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Aries v2.5(pass):
Build ID               20151010002512
Gaia Revision          74b0d4b17f39d238a7997800bd9363d3c60f20c3
Gaia Date              2015-10-09 19:27:39
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d1bb0de19476541cd517ab14017e7fedbd9f13e3
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151009.234251
Firmware Date          Fri Oct  9 23:42:59 UTC 2015
Bootloader             s1