1205294 - Empty Sync panel shows inaccurate string

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Darrin Henein [:darrin]]

The empty panel we are shipping in 1.0 tells the user that bookmarks will sync. They do not. 

This string should be changed to more correctly indicate what is being synced (and updated as we add more features).

Comment 1

[Darrin Henein [:darrin]]

Attachment: IMG_0943.PNG

Comment 2

[Robin Andersen [:tecgirl]]

While we're at it, do we sync passwords yet?

"Sync your tabs across devices"

Comment 3

[Richard Newman [:rnewman]]

We do sync passwords in 1.0.

We should make sure we have strings for both bookmarks and not, and perhaps worded for desktop-only ("mirror-ish", not "sync"), so we can switch without revving locales.

Comment 4

[Richard Newman [:rnewman]]

<darrin> rnewman: well we should have bookmarks in 1.1
<darrin> so we can kill that but if its not <1.1
<@rnewman> we can't get anything into a 1.0
<@rnewman> but I'd still be keen to have both strings available in 1.1
<darrin> rnewman: makes sense, just in case…?
<@rnewman> and perhaps something more ambiguous: "Get your tabs, bookmarks, and passwords from other devices"
<@rnewman> because tabs don't really *sync*
<@rnewman> and bookmarks won't for 1.1
<darrin> rnewman: lets track it then… can you add those comments into the bug?
<@rnewman> aye

Comment 5

[Richard Newman [:rnewman]]

Attachment: Pull request

Comment 6

[Richard Newman [:rnewman]]

Attachment: 5S

Comment 7

[Richard Newman [:rnewman]]

Attachment: 6+

Comment 8

[Stephan Leroux [:sleroux]]

Comment on attachment 8663057 [details] [review]
Pull request

Just a question about using a link in the localize comment.

Comment 9

[Robin Andersen [:tecgirl]]

Comment on attachment 8663057 [details] [review]
Pull request

I'm not sure this is really solving the problem. The header still states that 'Sync' is involved, for lack of actual product feature identity. But, if you two feel that this is at least less literal, I can go with it for now.

I'm also not crazy about how 'devices' is orphaned on its own line (in English, obviously). I know I can't win attempting pixel-perfection with strings—but I can at least hope to visually balance.

Comment 10

[Richard Newman [:rnewman]]

https://github.com/mozilla/firefox-ios/commit/2deb2ea2b8faca7eef390ea6edcc0d289e3e53d5

Orphan gone.

Comment 11

[Stefan Plewako [:stef]]

Both landed strings have inaccurate l10n comments.