1205388 - Autophone - better handle logcat collection

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

It has been possible for the logcat files uploaded to Treeherder to mix the output for a test different tests. It is also possible for the device's logcat buffer to overflow which may result in missing messages. This cleans up the logic by adding a Logcat.reset method which is used when a test job is setup. I unfortunately mixed up a small change to setup_job where I had to move some debugging log output as well.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: bug-1205388-v1.patch

Comment 2

[Geoff Brown [:gbrown]]

Comment on attachment 8661979 [details] [diff] [review]
bug-1205388-v1.patch

Review of attachment 8661979 [details] [diff] [review]:
-----------------------------------------------------------------

I prefer the approach used in http://hg.mozilla.org/mozilla-central/annotate/e7d613b3bcfe/testing/mozharness/scripts/android_emulator_unittest.py#l598 and that has worked well for me. I have some (minor) concern that special circumstances might still overflow the logcat buffer.

Comment 3

[Bob Clary [:bc] (inactive)]

If more than 256Kb on 2.3 or 512Kb on 4.x is written in 60s we will lose some. 60s is pretty long, I could reduce that a bit so that it would be less likely to overflow.

I like the dump to a file approach but am worried about the changes required to deal with the time periods ... setup_job .... teardown_job .... and with parsing the logcat output for the perftests. I'll leave it as is for now, but will look for opportunities to deal with dumping to external files. I'd definitely like to spend some time testing such a change.

Comment 4

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/5df25aa6536f06b67e691caa42cd892dbff3e699