Closed
Bug 1205389
Opened 9 years ago
Closed 9 years ago
Autophone - Update preferences for new SafeBrowsing prefs structure added in Bug 1107372
Categories
(Testing Graveyard :: Autophone, defect)
Testing Graveyard
Autophone
Tracking
(firefox43 affected)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | affected |
People
(Reporter: bc, Assigned: bc)
References
Details
Attachments
(1 file)
|
1.45 KB,
patch
|
gbrown
:
review+
|
Details | Diff | Splinter Review |
Bug 1107372 changed the safebrowsing preferences which has been causing intermittent crashes in production due to non-local network accesses. I haven't been able to reproduce the crashes here locally, but I believe these preference changes will fix it.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8661981 -
Flags: review?(gbrown)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8661981 [details] [diff] [review]
bug-1205389-v1.patch
Review of attachment 8661981 [details] [diff] [review]:
-----------------------------------------------------------------
::: phonetest.py
@@ +343,5 @@
> 'browser.safebrowsing.gethashURL': '',
> 'browser.safebrowsing.malware.enabled': False,
> 'browser.safebrowsing.malware.reportURL': '',
> + 'browser.safebrowsing.provider.google.appRepURL': '',
> + 'browser.safebrowsing.provider.google.updateURL': '',
I think you want "browser.safebrowsing.provider.google.gethashURL" as well.
|
|
Assignee | |
Comment 3•9 years ago
|
||
(In reply to François Marier [:francois] from comment #2)
Thanks! Added locally.
|
||
Updated•9 years ago
|
Attachment #8661981 -
Flags: review?(gbrown) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•3 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•