Closed Bug 1205470 Opened 5 years ago Closed 5 years ago

Assertion failure: !self->mInitPromise.IsEmpty(),

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox43 --- fixed
firefox44 --- fixed

People

(Reporter: jya, Assigned: jya)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, intermittent-failure, regression)

Attachments

(1 file)

From https://bugzilla.mozilla.org/show_bug.cgi?id=1105760#c465


PROCESS | 1863 | Assertion failure: !self->mInitPromise.IsEmpty(), at
/builds/slave/fx-team-l64-d-0000000000000000/build/src/dom/media/mediasource/MediaSourceDemuxer.cpp:66
PROCESS-CRASH | /media-source/SourceBuffer-abort-readyState.html | application
crashed [@
nsRunnableFunction<mozilla::MediaSourceDemuxer::NotifyDataArrived(uint32_t,
int64_t)::<lambda()> >::Run]
TEST-UNEXPECTED-CRASH | /media-source/SourceBuffer-abort-readyState.html |
expected OK
SSLError: [Errno 1] _ssl.c:1242: error:1409F07F:SSL
routines:SSL3_WRITE_PENDING:bad write retry
SSLError: [Errno 1] _ssl.c:1242: error:1409F07F:SSL
routines:SSL3_WRITE_PENDING:bad write retry
SSLError: [Errno 1] _ssl.c:1242: error:1409F07F:SSL
routines:SSL3_WRITE_PENDING:bad write retry
Return code: 1


We have a race accessing the init promise should shutdown occurs prior everything.
I had thought about and thought that it didn't matter. Prove njn's point I gather ; there's no such thing as a trivial race
Duplicate of this bug: 1206331
Can also remove mInitDone member as that information is redundant with the init promise being present
Attachment #8663476 - Flags: review?(cpearce)
Assignee: nobody → jyavenard
Attachment #8663476 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/44be220d93ec
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Comment on attachment 8663476 [details] [diff] [review]
[MSE] Remove assertion.

Approval Request Comment
[Feature/regressing bug #]:1204757
[User impact if declined]: Assert.
[Describe test coverage new/current, TreeHerder]: in central
[Risks and why]: Low, removing assertion
[String/UUID change made/needed]: none
Attachment #8663476 - Flags: approval-mozilla-aurora?
Seems this one flew under the radar... Any particular reason for the request to still be pending?

thank you
Flags: needinfo?(sledru)
Comment on attachment 8663476 [details] [diff] [review]
[MSE] Remove assertion.

Because I am managing 42 and not 43. Therefor, I am watching only the beta uplift requests.
Anyway, taking it to fix the assert.
Flags: needinfo?(sledru)
Attachment #8663476 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Ah ok . I see.. thanks
You need to log in before you can comment on or make changes to this bug.